use unwrapping mechanism for triangular matrices #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 93.84% 92.31% -1.53%
==========================================
Files 12 12
Lines 7521 7600 +79
==========================================
- Hits 7058 7016 -42
- Misses 463 584 +121
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Finally, finally! This not only contains modifications due to the unwrapping mechanism, but also a gentle rewiring of type unions. This was carefully tested with profiling in view of short load times. |
|
Ok, shall we merge? After this we should directly bump the stdlib, so I can do a little clean-up of intermediate left-overs, and then we should backport all of this as fast as possible to the alpha-release of v1.10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make use of JuliaLang/julia#50058 after that one is merged.