Reland new hvcat design (#406) #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2c7f4d6.
|
We should have new nightlies in a couple of days and be able to rerun these tests. |
|
Do we need to bump SparseArrays on Julia master for this? |
vtjnash
added a commit
that referenced
this pull request
Jul 12, 2023
Missed in #407, but causing doctest build to fail when we try to use this.
|
We need to be careful about what we merge into |
|
Ok, let's not merge any new features for now - and stabilize what we have including hvcat. |
|
The nightly is in decent shape now. So perhaps we can start merging. Do you want to do one merge and bump at a time so that we know things are in good shape incrementally? |
vtjnash
added a commit
that referenced
this pull request
Jul 12, 2023
Missed in #407, but causing doctest build to fail when we try to use this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening the reland commit as a followup after JuliaLang/julia#48977 is finished
Relands #384
Reverts #406