Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for SuiteSparse v7.4.0 #478

Merged
merged 8 commits into from
Jan 6, 2024
Merged

Update for SuiteSparse v7.4.0 #478

merged 8 commits into from
Jan 6, 2024

Conversation

giordano
Copy link
Contributor

@giordano giordano commented Dec 18, 2023

This goes with JuliaLang/julia#52577. All tests are passing, at least for aarch64-apple-darwin (the first platform to have finished running), but there are lots of warnings like

      From worker 10:	┌ Warning: CHOLMOD version incompatibility
      From worker 10:	│
      From worker 10:	│ Julia was compiled with CHOLMOD version 4.0.4. It is
      From worker 10:	│ currently linked with version 5.0.0.
      From worker 10:	│ This might cause Julia to terminate when working with
      From worker 10:	│ sparse matrix factorizations, e.g. solving systems of
      From worker 10:	│ equations with \.
      From worker 10:	│
      From worker 10:	│ It is recommended that you use Julia with the same major
      From worker 10:	│ version of CHOLMOD as the one used during the build, or
      From worker 10:	│ download the generic binaries from www.julialang.org,
      From worker 10:	│ which ship with the correct versions of all dependencies.
      From worker 10:	└ @ SparseArrays.CHOLMOD /Users/julia/.julia/scratchspaces/a66863c6-20e8-4ff4-8a62-49f30b1f605e/agent-cache/default-honeycrisp-R17H3W25T9.0/build/default-honeycrisp-R17H3W25T9-0/julialang/julia-master/julia-b3081f8082/share/julia/stdlib/v1.11/SparseArrays/src/solvers/cholmod.jl:206

My understanding is that we need to update these version numbers accordingly. I have no idea whether we need to do anything else.

Close #480, fix #482.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (feb54ee) 85.57% compared to head (5c8acc0) 85.58%.

❗ Current head 5c8acc0 differs from pull request most recent head 13ca4c9. Consider uploading reports for the commit 13ca4c9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   85.57%   85.58%   +0.01%     
==========================================
  Files          12       12              
  Lines        8832     8832              
==========================================
+ Hits         7558     7559       +1     
+ Misses       1274     1273       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Contributor Author

Note that now tests are are failing because I bumped the required version of SuiteSparse_jll, which isn't available in Julia yet, so that's expected, but tests were passing on the previous commit (note that macOS job was cancelled just because the job was taking longer than the other OSes, but tests were all successful to that point).

However I'd appreciate some help with figuring out this test failure in the julia repository, it only happens on 32-bit Windows: JuliaLang/julia#52577 (comment)

@ViralBShah
Copy link
Member

I think we should at least regenerate the wrappers and see what happens.

@giordano
Copy link
Contributor Author

giordano commented Jan 2, 2024

How? 🙂

@giordano giordano changed the title Update cholmod version number for SuiteSparse v7.3.0 Update for SuiteSparse v7.4.0 Jan 3, 2024
@giordano
Copy link
Contributor Author

giordano commented Jan 3, 2024

I included changes in #480, and am now running tests in JuliaLang/julia#52577 based on this PR. If tests are successful I suggest

@giordano
Copy link
Contributor Author

giordano commented Jan 5, 2024

@ViralBShah @rayegun can you please review and merge if/when ready? As a reminder, my suggested plan is outlined at #478 (comment)

@rayegun rayegun merged commit f890a1e into JuliaSparse:main Jan 6, 2024
0 of 6 checks passed
@ViralBShah
Copy link
Member

Thanks @giordano. Going forward, we should probably always upgrade the wrappers with every minor version update to SuiteSparse. Even longer term, it would be nice to move all this out of stdlib, although I wonder if upgradable stdlibs will actually make the upgrading experience a bit more pleasant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrapper generator needs updating to pick SuiteSparse headers from new location
5 participants