Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrappers for v7.4.0 #480

Closed
wants to merge 3 commits into from
Closed

Wrappers for v7.4.0 #480

wants to merge 3 commits into from

Conversation

rayegun
Copy link
Member

@rayegun rayegun commented Jan 2, 2024

Now we play a game of chicken. Which do we merge first? This or JuliaLang/julia#52577

@rayegun
Copy link
Member Author

rayegun commented Jan 2, 2024

Do not merge yet regardless, I need to test this locally and be sure there weren't technically breaking changes.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 97 lines in your changes are missing coverage. Please review.

Comparison is base (feb54ee) 85.57% compared to head (80c7812) 84.43%.

Files Patch % Lines
src/solvers/wrappers.jl 5.82% 97 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   85.57%   84.43%   -1.14%     
==========================================
  Files          12       12              
  Lines        8832     8874      +42     
==========================================
- Hits         7558     7493      -65     
- Misses       1274     1381     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giordano
Copy link
Contributor

giordano commented Jan 2, 2024

I think this should go together with #478.

@giordano
Copy link
Contributor

giordano commented Jan 2, 2024

Ah, test failures on nightly are the same as JuliaLang/julia#52577 (comment)

@rayegun
Copy link
Member Author

rayegun commented Jan 2, 2024

I really don't understand this permutation thing. I will try again to find the cause

@giordano
Copy link
Contributor

giordano commented Jan 2, 2024

Good news is that it seems to be reproducible on 32-bit Linux, which should be easier to debug than 32-bit Windows, as you can run the 32-bit build on a 64-bit Linux system.

@rayegun
Copy link
Member Author

rayegun commented Jan 2, 2024

Where can I download the 32-bit build?

@giordano
Copy link
Contributor

giordano commented Jan 2, 2024

Since the failure in CI is reproducible with a plain nightly build, you can use https://julialangnightlies-s3.julialang.org/bin/linux/i686/julia-latest-linux-i686.tar.gz (from https://julialang.org/downloads/nightlies/)

@rayegun rayegun closed this in #478 Jan 6, 2024
@DilumAluthge DilumAluthge deleted the rk/new-wrappers branch April 2, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants