This repository has been archived by the owner on May 4, 2019. It is now read-only.
Improve operators #119
Merged
Improve operators #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| null_safe_op(f::Any, ::Type)::Bool | ||
| null_safe_op(f::Any, ::Type, ::Type)::Bool | ||
|
|
||
| Returns whether an operation `f` can safely be applied to any value of the passed type(s). |
There was a problem hiding this comment.
Minor nit: maybe we should distinguish between value and bit pattern? Consider the following type:
immutable OneType
x::Int
function OneType()
new(1)
end
end
The only legal value of this type is 1, but our uninitialized constructors will generate bit patterns that are not legal values.
There was a problem hiding this comment.
Maybe we should mention "bit pattern" below instead of "domain"? I think "value" is good as a first approximation to give the idea of the requirements.
There was a problem hiding this comment.
OK, I've updated the docstring.
Current coverage is 81.61%@@ master #119 diff @@
==========================================
Files 13 13
Lines 729 729
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 598 595 -3
- Misses 131 134 +3
Partials 0 0
|
nalimilan
force-pushed
the
nl/ops
branch
2 times, most recently
from
92e3b27 to
bb9ba46
Compare
Introduce a new null_safe_op() function which is used instead of isbits() to decide whether to take the fast path (without a branch) or the slow path in lifted operators. This is more correct (and thus safer), and allows supporting operations on any type. Also add an extensive set of tests for both paths. On Julia 0.4, operators for which no functor exist cannot be identified by null_safe_op(): for these, fall back to the slow path on that version. This PR introduces cbrt as a new supported operation since it has a special operator ∛. It also keeps abs(), abs2(), scalarmin() and scalarmax(), which should probably be deprecated once we have a more general solution for lifting.
Nullable{Union{}} is always null so we can return null immediately
if one of the arguments is of that type. For unary operators, return
Nullabl(). For binary operators, return Nullable{S}() with S the element
type of the other argument, which carries more information.
|
With support merged in Julia, tests now pass. Will tag a new release. |
This was referenced Sep 15, 2016
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
null_safe_op()function which is used instead ofisbits()to decide whether to take the fast path (without a branch)or the slow path in lifted operators. This is more correct (and thus
safer), and allows supporting operations on any type. Also add an
extensive set of tests for both paths.
On Julia 0.4, operators for which no functor exist cannot be identified
by
null_safe_op(): for these, fall back to the slow path on that version.This PR introduces
cbrtas a new supported operation since it has a specialoperator
∛. It also keepsabs(),abs2(),scalarmin()andscalarmax(), whichshould probably be deprecated once we have a more general solution for
lifting.
Tests pass on Julia 0.4, but on 0.5 they need JuliaLang/julia#16995 (unrelated tests already fail too).
Fixes #74, #111, #116.