Bug-fixes and more options. #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… know the risks and want to take them.
…e-defined arguments to be aliased as well as simple renames.
These are not recommended to be changed. Basically only for debug / ye-who-knows. I will not provide ANY support for these, use them at your own risk!
Does not affect autoplaylist tracks, as they are added 1x1 while q is empty.
… current entry playback. Note that this seems to create some jitter in audio playback while download is ongoing.
BabyBoySnow
reviewed
Jul 23, 2024
itsTheFae
added a commit
to itsTheFae/MusicBot
that referenced
this pull request
Jul 24, 2024
BabyBoySnow
added a commit
to BabyBoySnow/Fae-MusicBot
that referenced
this pull request
Jul 29, 2024
* Add technical support for cookies.txt passed to yt-dlp. For those who know the risks and want to take them.
* Remove unused code.
* Fix to_ini for debug level config
* Add dev-only command to make markdown from config / permissions code.
* Fix AttributeError with out-of-date colorama on windows.
* Fix exception handling if aiohttp import fails.
* Add ffmpeg start-up check.
* Use pypi release 2.4.0 or higher of discord.py
* Ensure windows has colorama 0.4.6+ if colorlog does not require it.
* Remove pre-commit
* Change version constant and modification detection logic.
* Remove todo.
* linting f-strings
* remove todo
* Add support for spaces in aliased commands, enabling commands with pre-defined arguments to be aliased as well as simple renames.
* format
* More format changes.
* Make debug command more debug-y
* Create some UA string "options" via constants.
These are not recommended to be changed. Basically only for debug / ye-who-knows.
I will not provide ANY support for these, use them at your own risk!
* add note about PCMVolumeTransformer
* Add TODO for local playback feature(s)
* format & lint
* Pre-download next track in queue.
Does not affect autoplaylist tracks, as they are added 1x1 while q is empty.
* format
* lints
* Add option for status message to count paused players, off by default.
* Make pre-download happen a tad later to reduce network congestion for current entry playback.
Note that this seems to create some jitter in audio playback while download is ongoing.
* Better checks for player inactivity.
* Experimental proxy option for ytdlp.
* Remove bogus statement about {n_paused} status message variable.
* Add UA changing option to ini config.
* Revise options and help texts for PR Just-Some-Bots#2416
* Add owner-only command to manage cookies.
* Ensure ytdlp rotates UA strings with each request, while not set static.
* Add warning to setcookies help text.
* Make header check timeout errors graceful.
* format
* Change MusicBot to bot's username in uptime command.
* format and lint
* Fix typo and copy-paste blunder.
---------
Co-authored-by: itsTheFae <itsthefae@gmail.com>
BabyBoySnow
added a commit
to BabyBoySnow/Fae-MusicBot
that referenced
this pull request
Sep 7, 2024
commit 59fca37 Author: itsTheFae <itsthefae@gmail.com> Date: Fri Sep 6 12:36:50 2024 -0700 Add detected OS to install.sh --list commit 4d4987e Author: itsTheFae <itsthefae@gmail.com> Date: Fri Sep 6 12:05:27 2024 -0700 add default case to pop OS commit 7d718bc Author: itsTheFae <itsthefae@gmail.com> Date: Fri Sep 6 11:53:30 2024 -0700 Add PopOS 24.04 and Shellcheck updates commit 8783aa2 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 19:34:59 2024 -0700 do testing with debian, and update --list commit 2fe6854 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 16:54:27 2024 -0700 ignore activity timer when voice client is already disconnected commit f46c10a Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 15:37:14 2024 -0700 Fix playnext not respecting playlists commit 797c2d7 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 15:07:54 2024 -0700 fix my typo commit e31351b Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 15:02:37 2024 -0700 clip seek time floats with .2f commit 7d5670a Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 15:01:28 2024 -0700 try detecting venv for pip upgrade step. commit bb7dfe7 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 14:28:24 2024 -0700 Don't mind me, just using the wrong paths and stuff... commit 846fa8e Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 14:15:51 2024 -0700 Fix relative seek and improve feedback of seek command. commit a03f041 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 14:18:53 2024 -0700 Make run.sh and update.sh check for venv. commit 434098a Author: itsTheFae <itsthefae@gmail.com> Date: Thu Sep 5 13:36:10 2024 -0700 Add Ubuntu 24.xx installer. Minor update to debian 12 & added 13 - needs testing. commit c02cc59 Author: itsTheFae <itsthefae@gmail.com> Date: Fri Aug 30 17:09:19 2024 -0700 make sure to set default value in new example options. commit e125695 Author: itsTheFae <itsthefae@gmail.com> Date: Fri Aug 30 21:55:59 2024 -0700 update some example options. tweak how getbool fails. add getstr for explicit strip of whitespace and fallback on empty. commit fcef76e Author: itsTheFae <itsthefae@gmail.com> Date: Fri Aug 30 12:56:48 2024 -0700 Address the extractor permissions being too strict and thus confusing. This also updates some inconsistent documentation and logic around allowing all extractors. commit 45fce84 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Aug 29 17:52:34 2024 -0700 Fix stacklevel for windows again. commit 5fc2330 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Aug 29 09:45:12 2024 -0700 handle ModuleNotFoundError when checking for OAuth2 plugin. commit 41113e5 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Aug 29 09:17:05 2024 -0700 Enable ytdlp logging with original oauth2 plugin. Updates the warning about original plugin use. commit e190298 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Aug 29 08:52:40 2024 -0700 Updates for lint / formatting. commit 9978455 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Aug 29 08:52:05 2024 -0700 fix typo with importlib. commit 1bf894b Author: itsTheFae <itsthefae@gmail.com> Date: Wed Aug 28 19:39:29 2024 -0700 Integrate the OAuth2 plugin as optional. Uses original library if it is installed, to prevent conflicts and provide easier testing. commit 8ddbc68 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Aug 11 17:15:54 2024 -0700 format original source code commit 29bab2f Author: itsTheFae <itsthefae@gmail.com> Date: Sun Aug 11 17:10:17 2024 -0700 Commit original code with notice of origin and license. commit 4284e5e Author: itsTheFae <itsthefae@gmail.com> Date: Mon Aug 5 18:43:16 2024 -0700 Fix missing playback_speed on streamed entries. commit c0823fb Author: itsTheFae <itsthefae@gmail.com> Date: Mon Aug 5 18:46:47 2024 -0700 Update requirements.txt for windows aiodns bug. Conflicts: requirements.txt commit 2be72e7 Author: itsTheFae <itsthefae@gmail.com> Date: Mon Aug 5 17:42:59 2024 -0700 Fix windows install.ps1 hanging if winget terms are not accepted yet. Minor changes to description / informative text. commit e2fa9e2 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 28 22:05:06 2024 -0700 Fix typo and copy-paste blunder. commit e5f945b Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 28 20:42:33 2024 -0700 format and lint commit 392581a Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 28 20:30:27 2024 -0700 Change MusicBot to bot's username in uptime command. commit bffdbce Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 28 20:04:20 2024 -0700 format commit 590bf43 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 28 19:59:57 2024 -0700 Make header check timeout errors graceful. commit c3c340e Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 28 19:47:02 2024 -0700 Add warning to setcookies help text. commit eab4104 Author: itsTheFae <itsthefae@gmail.com> Date: Sat Jul 27 20:54:42 2024 -0700 Ensure ytdlp rotates UA strings with each request, while not set static. commit 090cc27 Author: itsTheFae <itsthefae@gmail.com> Date: Sat Jul 27 20:53:07 2024 -0700 Add owner-only command to manage cookies. commit 9906691 Author: itsTheFae <itsthefae@gmail.com> Date: Tue Jul 23 18:16:55 2024 -0700 Revise options and help texts for PR Just-Some-Bots#2416 commit 107bccd Author: itsTheFae <itsthefae@gmail.com> Date: Tue Jul 23 12:41:49 2024 -0700 Add UA changing option to ini config. commit f2175a4 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 21 11:01:09 2024 -0700 Remove bogus statement about {n_paused} status message variable. commit 22f3bfa Author: itsTheFae <itsthefae@gmail.com> Date: Mon Jul 22 22:04:50 2024 -0700 Experimental proxy option for ytdlp. commit b37595c Author: itsTheFae <itsthefae@gmail.com> Date: Sat Jul 20 18:47:58 2024 -0700 Better checks for player inactivity. commit 183b4be Author: itsTheFae <itsthefae@gmail.com> Date: Sat Jul 20 18:40:24 2024 -0700 Make pre-download happen a tad later to reduce network congestion for current entry playback. Note that this seems to create some jitter in audio playback while download is ongoing. commit 73d9679 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 17:21:17 2024 -0700 Add option for status message to count paused players, off by default. commit 9a6e894 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 17:20:07 2024 -0700 lints commit e92a179 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 17:18:17 2024 -0700 format commit d41aad9 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 15:46:02 2024 -0700 Pre-download next track in queue. Does not affect autoplaylist tracks, as they are added 1x1 while q is empty. commit e269234 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 11:09:21 2024 -0700 format & lint commit bbdb1ca Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 11:01:52 2024 -0700 Add TODO for local playback feature(s) commit ecdd850 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 11:01:08 2024 -0700 add note about PCMVolumeTransformer commit 9a2386b Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 11:00:11 2024 -0700 Create some UA string "options" via constants. These are not recommended to be changed. Basically only for debug / ye-who-knows. I will not provide ANY support for these, use them at your own risk! commit 150e6fb Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 10:47:59 2024 -0700 Make debug command more debug-y commit 4d5bcd0 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 07:59:23 2024 -0700 More format changes. commit e347d4c Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 07:47:58 2024 -0700 format commit 13a9a68 Author: itsTheFae <itsthefae@gmail.com> Date: Thu Jul 18 07:46:56 2024 -0700 Add support for spaces in aliased commands, enabling commands with pre-defined arguments to be aliased as well as simple renames. commit ee5fde2 Author: itsTheFae <itsthefae@gmail.com> Date: Tue Jul 16 10:39:46 2024 -0700 remove todo commit 6056364 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 14 15:51:35 2024 -0700 linting f-strings commit af4f2a6 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 14 15:44:39 2024 -0700 Remove todo. commit dcb71c4 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 14 15:42:23 2024 -0700 Change version constant and modification detection logic. commit 23563e3 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 14 12:29:31 2024 -0700 Remove pre-commit commit 963673e Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 14 12:29:01 2024 -0700 Ensure windows has colorama 0.4.6+ if colorlog does not require it. commit 834b325 Author: itsTheFae <itsthefae@gmail.com> Date: Sun Jul 14 12:25:20 2024 -0700 Use pypi release 2.4.0 or higher of discord.py commit 9e01218 Author: itsTheFae <itsthefae@gmail.com> Date: Fri Jul 12 15:37:25 2024 -0700 Add ffmpeg start-up check. commit 9fdf56f Author: itsTheFae <itsthefae@gmail.com> Date: Fri Jul 12 11:03:22 2024 -0700 Fix exception handling if aiohttp import fails. commit 4df63d1 Author: itsTheFae <itsthefae@gmail.com> Date: Wed Jul 10 08:32:58 2024 -0700 Fix AttributeError with out-of-date colorama on windows. commit 4f96235 Author: itsTheFae <itsthefae@gmail.com> Date: Tue Jul 9 19:29:07 2024 -0700 Add dev-only command to make markdown from config / permissions code. commit 1e4c16d Author: itsTheFae <itsthefae@gmail.com> Date: Tue Jul 9 19:27:41 2024 -0700 Fix to_ini for debug level config commit 955a1d2 Author: itsTheFae <itsthefae@gmail.com> Date: Tue Jul 9 19:23:29 2024 -0700 Remove unused code. commit c3a4784 Author: itsTheFae <itsthefae@gmail.com> Date: Tue Jul 9 19:22:56 2024 -0700 Add technical support for cookies.txt passed to yt-dlp. For those who know the risks and want to take them.
BabyBoySnow
added a commit
to BabyBoySnow/Fae-MusicBot
that referenced
this pull request
Oct 25, 2024
* remove pre commit as a requirment Didn't work as desired. Leaving files for those who want to use pre commit * lnp inside of summon cmd Sets lnp inside the summon command for various instances when it's needed. A quality of life change surely. * update self summon to pass message Added setting lnp in summon, which uses message so we need to pass it in our calls. * new black version * update binaries * Revert "update binaries" This reverts commit 76e7d36. * update binaries * Revert "update binaries" This reverts commit 0d3b768. * General stability updates. (Just-Some-Bots#2394) * just debug logs mostly * Reorganize a little bit of logging at startup. still debugging though. * This should just be empty, for now... * clean up some logs. * no more async main in run.py. This refactors further signal and shutdown handling for the bot. * Fix up pip install attempt and make code checks happy. * Set console title in run.py main. Improve some more logic with graceful recovery cases. Fix some check complaints. * More fixes for graceful startup and shutdown on windows. * Use asyncio not self.loop. * Ensure restart still works as expected. * More fixes * pylint * restructure how on-ready fires other events. try not to send updates while on_ready runs first time. * fix the obviously broken bits. * Fix --no-checks only skip optional checks. Also log python version. * refine some exception handling in auto playlists and on shutdown. * Fix logic issue with auto playlist. * improve replace in autoplaylist. * Allow run.bat and run.sh to pass CLI args to python. Simplify checks done in run.sh. * Bootleg connection resumption. Probably still busted and shitty, but it's close. * Fix custom log functions to use stacklevel 2 on windows. Organize log formats in order of log level number. * correct stacklevel ... * Update voice_state_update warning to be more clear. * Create player is no serialized player exists. oops. :) * Ensure auto playlists actually kick off in non-serialized guild. * run formatting and tidy up some spam. * Move auto_pause and availability into MusicPlayer. * Change status updates to run on disconnect again, also adds an offline status for logout/shutdown. * Prevent deadlock if exception is thrown in signal handler. * change guild auto pause handler to wait for connection. * Update player.py formatting * Update network test with ICMP ping via sub process call * Make sure old queue.json does not stop the show. * Use shutil.which() to get ping binary path. Tries to catch errors from sys call. * Make sure shutil also fails gracefully. * proper 3.8 compatible types should be part of this too. * Copy over some missing changes. * Attempt to handle the discord API connection termination. * Fix backward logic. * Don't resume an auto-paused player when returning from network outage. * Fix race condition in unpause check. * remove entry_added check in favor of check on play * refactor playlist entry meta and handle auto-playlist expansion of playlist links differently. also disables extraction logs. also adds indicator for autoplaylist entries, though none should be enqueued to playlist queue now. * Try to avoid excessive auto-pause retry when player is being discarded/reconnected. * Attempt to rejoin on API termination when configured to auto-join. If auto-join bot is moved, attempt to join old channel instead. * remove redundant calls to finish_playing event. * Fix error with rouge player check in disconnect_all_voice_clients * Now playing messages should not repeat on reconnect. * fix erroneous logic in last_np_msg content check. * dyslexic logic strikes again. gotta love it. * Add more sanity checks to play-invoked unpause. Allow unpause check to trigger summon if perms.summonplay is set. * update self summon to pass message Added setting lnp in summon, which uses message so we need to pass it in our calls. * lnp inside of summon cmd Sets lnp inside the summon command for various instances when it's needed. A quality of life change surely. * last_np_msg should actually compare the content of embed and not just the hash in the collection. I'm an idiot. : ) * Track last played song subject for better control of last now playing message. * format fix * Respect queue persist option, and make sure auto-playlist starts without a queue. --------- Co-authored-by: Snow <135516526+BabyBoySnow@users.noreply.github.com> * use essentials build Use a newer binary file. * Updates for the Installer and Updater scripts. (Just-Some-Bots#2395) * Updates for installer and update scripts. Adds ffmpeg install step to install.ps1 using winget tool Installers now prompt before installing. SysD service file requires user and group settings. * Update requirements.txt to use voice and speed options for discord.py repo pull. * Round robin patch (Just-Some-Bots#2396) * Fix index errors in reorder_for_round_robin function. * Update comments * Add commands for config and permission editing and reloading. (Just-Some-Bots#2397) * Add commands for config and permission editing and reloading. Refactors how options are registered, and adds a new dependency configupdater. * Update example_options.ini * Some fixes for setperms * remove unused bootstrap and travis files. (Just-Some-Bots#2400) * Installer updates (Just-Some-Bots#2401) * Update install.sh to work in cloned directory. * Update install.ps1 to work in cloned directory, and clean up some output. * Update install.bat to be more informative and less lazy. * Update run.py to show pip packages when checking, and handle missing discord.py when extensions are installed. * Tidy up comments * Update comment for disk check option. * Don't forget TerminateSignal can set an exit code now. * Remove refreshenv call * Seek and speed features (Just-Some-Bots#2402) * Adds seeking and playback speed support. * Update example_options.ini * Add relative seek. * Add multi-playlist support and local media support. (Just-Some-Bots#2403) * Bug fixes, QOL tweaks, and code clean up. (Just-Some-Bots#2404) * Bug fixes, QOL tweaks, and code clean up. * Fix regression of relative seek. * Add the follow command * Add latency and botlatency commands. (Just-Some-Bots#2406) * Add uptime command (Just-Some-Bots#2407) Co-authored-by: Snow <135516526+BabyBoySnow@users.noreply.github.com> * fix broken resolve * add some with multiple add latency as ping * Provide option for auto-unpause, default off. (Just-Some-Bots#2408) * Provide option for auto-unpause, default off. * Add option to example_options.ini * add sub command reset adds an option to reset config options to default as defined in ConfigDefaults. Maybe find a way to create option_defaults.ini for use here? * Update some command help text. * Potentially fix high-cpu deadlock bug. (Just-Some-Bots#2411) * Attempt to squash the high-cpu bug. - Make play calls explicit, rather than implied through adding entries. - Handle player errors and ensure progress of queue or autoplaylist. - Prevent early garbage collection of created async tasks. - Run shutdown on downloader thread pool. Waits threads rather than let them dangle. - Reduce usage of infinite loops and update some logging. * Make pylint happy with 3.8 compatible call. * Ensure task exceptions are retrieved by the done callback. * Try to read ffmpeg stderr stream until playback stops or an exception is set. * return player to stopped state for playback finished or it wont restart later... * Deal with aiohttp client errors in the safe_*_message functions... * Move stderr future checking before the return statements in _playback_finished callback. Otherwise that could loop infinitely... * Bug-fixes and more options. (Just-Some-Bots#2416) * Add technical support for cookies.txt passed to yt-dlp. For those who know the risks and want to take them. * Remove unused code. * Fix to_ini for debug level config * Add dev-only command to make markdown from config / permissions code. * Fix AttributeError with out-of-date colorama on windows. * Fix exception handling if aiohttp import fails. * Add ffmpeg start-up check. * Ensure windows has colorama 0.4.6+ if colorlog does not require it. * Change version constant and modification detection logic. * remove todo * Add support for spaces in aliased commands, enabling commands with pre-defined arguments to be aliased as well as simple renames. * format * More format changes. * Make debug command more debug-y * Create some UA string "options" via constants. These are not recommended to be changed. Basically only for debug / ye-who-knows. I will not provide ANY support for these, use them at your own risk! * add note about PCMVolumeTransformer * format & lint * Pre-download next track in queue. Does not affect autoplaylist tracks, as they are added 1x1 while q is empty. * format * lints * Add option for status message to count paused players, off by default. * Make pre-download happen a tad later to reduce network congestion for current entry playback. Note that this seems to create some jitter in audio playback while download is ongoing. * Better checks for player inactivity. * Remove TODO and format. * Remove bogus statement about {n_paused} status message variable. * Experimental proxy option for ytdlp. * Add UA changing option to ini config. * Revise options and help texts for PR Just-Some-Bots#2416 * Cookie management command & bug fix (Just-Some-Bots#2417) * Add owner-only command to manage cookies. * Ensure ytdlp rotates UA strings with each request, while not set static. * Add warning to setcookies help text. * Make header check timeout errors graceful. * format * Change MusicBot to bot's username in uptime command. * format and lint * Fix typo and copy-paste blunder. * Windows patches 2024-08-05 (Just-Some-Bots#2418) * Fix windows install.ps1 hanging if winget terms are not accepted yet. Minor changes to description / informative text. * Update requirements.txt for windows aiodns bug. * Fix missing playback_speed on streamed entries. (Just-Some-Bots#2419) * Ytdlp oauth2 plugin integration (Just-Some-Bots#2421) * Commit original code with notice of origin and license. * format original source code * Integrate the OAuth2 plugin as optional. Uses original library if it is installed, to prevent conflicts and provide easier testing. * fix typo with importlib. * Updates for lint / formatting. * Enable ytdlp logging with original oauth2 plugin. Updates the warning about original plugin use. * handle ModuleNotFoundError when checking for OAuth2 plugin. * Address the extractor permissions being too strict and thus confusing. This also updates some inconsistent documentation and logic around allowing all extractors. * Update Examples and adjust config parser. (Just-Some-Bots#2422) * make sure to set default value in new example options. * update some example options. tweak how getbool fails. add getstr for explicit strip of whitespace and fallback on empty. * Bugfix 20240905 (Just-Some-Bots#2423) * Fix relative seek and improve feedback of seek command. * format seek time floats * Fix playnext not respecting playlists * ignore activity timer when voice client is already disconnected * speed handled upstream since we pull directly, no need to wait to revert this until it's pushed to pypi * Installer updates mostly (Just-Some-Bots#2428) * Add Ubuntu 24.xx installer. Minor update to debian 12 & added 13 - needs testing. * Make run.sh and update.sh check for venv. * More compatibility with venv installs * do testing with debian, and update --list * Add PopOS 24.04 and Shellcheck updates * add default case to pop OS * Add detected OS to install.sh --list * Allow bypass of system package steps or of musicbot install steps. * more tweaks and options * use pypi discord.py * try to add install path option * no = supported here * Move the default check. * Clean up service install. Remove cli alias as unsupported. Adjust post install message for venv. Add --no-sudo option. * more service install tweaks * output formatting * don't touch options.ini if it exists already. fix copy and sed. * service setup assumes previous cd to clone dir. * Turn the template into just an example file. Installer now has its own internal template to generate service files. * add / change warning about install directory with --service option. * more output tweaks * Ap add all (itsTheFae#6) Adds new sub-command as `autoplaylist [+ | add] all` which allows users to add all songs in the queue to the auto playlist. Conflicts: musicbot/bot.py * Use discord via git repo ... test test test I should have left the installers broken... * Add some root/sudo checks. * Try to install winget and restart for env vars. * Fix env vars maybe, add file extension un-hide logic * Add anybranch option, fix ffmpeg error when installed but no update. * Install path and cleaning output. * fix winget issues with ffmpeg * set appropriate repo url. * checks * add certificate pre-fetch to installer... * add lock to summon. also tidy code * Fix extractor checks to work with and without plugins like oauth2. SpotifyPlaylist objects only allow track member types. * fix summon message on stream * Status msg total should use player count when paused counting is not enabled. * add request to speak logic * Move to a function instead * needs some tlc but sufficient it's really glitchy, and needs cleaned up most likely * refactor stage handling update to handle case where we're moved to audience by a staff * add some comments remove one * unify behavior * add todo * follow similar patterns * it's not always staff * prevent blocking uses unique key to make sure we don't block connecting to stages in different servers * black it --------- Co-authored-by: Fae <itsthefae@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
devbranch (the latest developmental version), and this pull request is targeting that branch as a baseDescription
This PR contains a few patches for stability, some corrections to features, and also adds new config options to tweak some of ytdlp's network related settings.
Some of these patches will need some extra testing on windows or with python 3.8 to be sure they work. As always, feel free to deny this PR and cherry-pick the parts that are most useful.
A summary list of changes:
cookies.txtby adding the fileMusicBot/data/cookies.txtto enable cookies. Must not be empty!bin/exes.Related issues (if applicable)
Alias support was expanded on, potentially closing issue #2413