Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columnstore Index operations shown as Clustered Index operations #82

Closed
JustinPealing opened this issue Sep 25, 2018 · 0 comments
Closed
Labels
Milestone

Comments

@JustinPealing
Copy link
Owner

JustinPealing commented Sep 25, 2018

For an example plans see:

test_plans/Columnstore/columnstore_index_insert.sqlplan
image

test_plans/Columnstore/columnstore_index_delete.sqlplan
image

test_plans/Columnstore/columnstore_index_update.sqlplan
image

test_plans/Columnstore/columnstore_index_merge.sqlplan
image

@JustinPealing JustinPealing added this to the 2.6 milestone Sep 25, 2018
@JustinPealing JustinPealing changed the title Columnstore Index Insert shown as "Clustered Index Insert" Columnstore Index operations shown as Clustered Index operations Sep 25, 2018
anthonydresser pushed a commit to anthonydresser/html-query-plan that referenced this issue Feb 5, 2019
* Update npm packages

* Fix typo estimatestimatedRowSize => estimatedRowSize

* Completed buildLineTooltip

This function builds a tooltip for a line - exported from the tooltip module to allow unit testing.

* JustinPealing#71 Add .npmignore

Want to include the dist folder in npm, but not in git.
lib folder is no longer used - dist is used instead.

* Replace Windows build instructions with bash instructions

* Add "smoothing" for lines

Sometimes the median point of two nodes on the same "level" won't quite line up, and arrows that should be straight are drawn with a small bend. This check should hopefully smooth that out in most cases.

* JustinPealing#14 Add "Number of Rows Read" to line tooltip.

Managed to miss this property when I implemented this earlier.

* Fix build command in readme

* JustinPealing#14 Fix "null" shown in line tooltip.

* Adjust convertSize to convert to MB

* JustinPealing#74 Add Estimated Operator Cost to all nodes

Was previously hidden from root nodes as it could display NaN, instead its been defensively coded and so the condition to hide it can be removed.

* Fix error when trying to show tooltip for nodes which are not of type RelOp

For now just don't show the tooltip

* Increase minimum line thickness

* Fix unit tests failing because node thickness increased

* Increase version number in package.json

* Replace screenshot with 2.5 version

* Bump version again

To get around accidentally publishing the wrong version to npm

* Use textContent in place of innerText

To fix tests in firefox, see:
https://stackoverflow.com/questions/1359469/innertext-works-in-ie-but-not-in-firefox

* Update typescript, webpack and karma

* Regenerate package-lock.json

* JustinPealing#75 Add icon for bitmap

* JustinPealing#75 Add icon for COND

* JustinPealing#75 Add icon for Columnstore Index Scan

Also added icons for other columnstore operations, just need to add test cases.

* JustinPealing#75 Add test + css for Columnstore Index Insert icon

* JustinPealing#75 add test for Columnstore Index Delete icon

* Add test plan for Columnstore Index Update icon

* JustinPealing#75 Test case + css for Columnstore Index Merge icon

* JustinPealing#75 Populate Query

* JustinPealing#75 Sequence Project icon

* JustinPealing#75 Snapshot icon

* JustinPealing#75 Icon for clustered index merge

* JustinPealing#75 Add icon for Deleted Scan

Also fix tests for Clustered Index Merge icon

* Add icon for Index Insert

* JustinPealing#75 Fix icon for index spool

* JustinPealing#75 Add guesses for IndexDelete and IndexUpdate icons

* JustinPealing#75 add icon for table merge

* JustinPealing#75 fix icon for UDX nodes

* JustinPealing#75 add unit test for Window Aggregate icon

* JustinPealing#75 Update Catchall icon to a "C" icon

Mostly used for cursors.

* JustinPealing#75 Add icon for adaptive join

* JustinPealing#75 add example plan for "Batch Hash Table Build"

* JustinPealing#75 Add test plan for index delete

* JustinPealing#75 add test plan for index update

* Fix extension for test plan

* Add icon for "Batch Hash Table Build"

* JustinPealing#75 Add icon for Window Spool

* Add icon for Window Aggregate

* Fix filename for test plan

* npm install

* JustinPealing#82 - Fix Columnstore Index node labels

* Initial implementation

* Unit tests for execution mode icon

The "Actual" execution mode overrides the estimated execution mode, if present.

Mangled a couple of execution plans to provide test cases for the "ovveriding".

* Adjust positon of 16x16 icons

* Document "overlay" icons

* Fix webpack minify config

* Update version number

* Fix npm version number
anthonydresser pushed a commit to anthonydresser/html-query-plan that referenced this issue Nov 16, 2019
* Update npm packages

* Fix typo estimatestimatedRowSize => estimatedRowSize

* Completed buildLineTooltip

This function builds a tooltip for a line - exported from the tooltip module to allow unit testing.

* JustinPealing#71 Add .npmignore

Want to include the dist folder in npm, but not in git.
lib folder is no longer used - dist is used instead.

* Replace Windows build instructions with bash instructions

* Add "smoothing" for lines

Sometimes the median point of two nodes on the same "level" won't quite line up, and arrows that should be straight are drawn with a small bend. This check should hopefully smooth that out in most cases.

* JustinPealing#14 Add "Number of Rows Read" to line tooltip.

Managed to miss this property when I implemented this earlier.

* Fix build command in readme

* JustinPealing#14 Fix "null" shown in line tooltip.

* Adjust convertSize to convert to MB

* JustinPealing#74 Add Estimated Operator Cost to all nodes

Was previously hidden from root nodes as it could display NaN, instead its been defensively coded and so the condition to hide it can be removed.

* Fix error when trying to show tooltip for nodes which are not of type RelOp

For now just don't show the tooltip

* Increase minimum line thickness

* Fix unit tests failing because node thickness increased

* Increase version number in package.json

* Replace screenshot with 2.5 version

* Bump version again

To get around accidentally publishing the wrong version to npm

* Use textContent in place of innerText

To fix tests in firefox, see:
https://stackoverflow.com/questions/1359469/innertext-works-in-ie-but-not-in-firefox

* Update typescript, webpack and karma

* Regenerate package-lock.json

* JustinPealing#75 Add icon for bitmap

* JustinPealing#75 Add icon for COND

* JustinPealing#75 Add icon for Columnstore Index Scan

Also added icons for other columnstore operations, just need to add test cases.

* JustinPealing#75 Add test + css for Columnstore Index Insert icon

* JustinPealing#75 add test for Columnstore Index Delete icon

* Add test plan for Columnstore Index Update icon

* JustinPealing#75 Test case + css for Columnstore Index Merge icon

* JustinPealing#75 Populate Query

* JustinPealing#75 Sequence Project icon

* JustinPealing#75 Snapshot icon

* JustinPealing#75 Icon for clustered index merge

* JustinPealing#75 Add icon for Deleted Scan

Also fix tests for Clustered Index Merge icon

* Add icon for Index Insert

* JustinPealing#75 Fix icon for index spool

* JustinPealing#75 Add guesses for IndexDelete and IndexUpdate icons

* JustinPealing#75 add icon for table merge

* JustinPealing#75 fix icon for UDX nodes

* JustinPealing#75 add unit test for Window Aggregate icon

* JustinPealing#75 Update Catchall icon to a "C" icon

Mostly used for cursors.

* JustinPealing#75 Add icon for adaptive join

* JustinPealing#75 add example plan for "Batch Hash Table Build"

* JustinPealing#75 Add test plan for index delete

* JustinPealing#75 add test plan for index update

* Fix extension for test plan

* Add icon for "Batch Hash Table Build"

* JustinPealing#75 Add icon for Window Spool

* Add icon for Window Aggregate

* Fix filename for test plan

* npm install

* JustinPealing#82 - Fix Columnstore Index node labels

* Initial implementation

* Unit tests for execution mode icon

The "Actual" execution mode overrides the estimated execution mode, if present.

Mangled a couple of execution plans to provide test cases for the "ovveriding".

* Adjust positon of 16x16 icons

* Document "overlay" icons

* Fix webpack minify config

* Update version number

* Fix npm version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant