Merge latest upstream html-query-plan changes #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function builds a tooltip for a line - exported from the tooltip module to allow unit testing.
Want to include the dist folder in npm, but not in git. lib folder is no longer used - dist is used instead.
Sometimes the median point of two nodes on the same "level" won't quite line up, and arrows that should be straight are drawn with a small bend. This check should hopefully smooth that out in most cases.
Managed to miss this property when I implemented this earlier.
Was previously hidden from root nodes as it could display NaN, instead its been defensively coded and so the condition to hide it can be removed.
… RelOp For now just don't show the tooltip
To get around accidentally publishing the wrong version to npm
To fix tests in firefox, see: https://stackoverflow.com/questions/1359469/innertext-works-in-ie-but-not-in-firefox
Also added icons for other columnstore operations, just need to add test cases.
Mostly used for cursors.
The "Actual" execution mode overrides the estimated execution mode, if present. Mangled a couple of execution plans to provide test cases for the "ovveriding".
|
@anthonydresser could you please take a look at this when you have a chance? |
anthonydresser
approved these changes
Feb 5, 2019
|
@anthonydresser are you planning to merge into the release branch, create a new release, and update ADS references? Or should I send a PR for that? Alternatively, if you add permissions for me to managing this repo I can do this. |
|
I created a release 2.6 https://github.com/anthonydresser/html-query-plan/releases/tag/2.6 |
|
@anthonydresser thanks! I should have checked before asking I guessing 😄. |
anthonydresser
pushed a commit
that referenced
this pull request
Nov 16, 2019
* Update npm packages * Fix typo estimatestimatedRowSize => estimatedRowSize * Completed buildLineTooltip This function builds a tooltip for a line - exported from the tooltip module to allow unit testing. * JustinPealing#71 Add .npmignore Want to include the dist folder in npm, but not in git. lib folder is no longer used - dist is used instead. * Replace Windows build instructions with bash instructions * Add "smoothing" for lines Sometimes the median point of two nodes on the same "level" won't quite line up, and arrows that should be straight are drawn with a small bend. This check should hopefully smooth that out in most cases. * JustinPealing#14 Add "Number of Rows Read" to line tooltip. Managed to miss this property when I implemented this earlier. * Fix build command in readme * JustinPealing#14 Fix "null" shown in line tooltip. * Adjust convertSize to convert to MB * JustinPealing#74 Add Estimated Operator Cost to all nodes Was previously hidden from root nodes as it could display NaN, instead its been defensively coded and so the condition to hide it can be removed. * Fix error when trying to show tooltip for nodes which are not of type RelOp For now just don't show the tooltip * Increase minimum line thickness * Fix unit tests failing because node thickness increased * Increase version number in package.json * Replace screenshot with 2.5 version * Bump version again To get around accidentally publishing the wrong version to npm * Use textContent in place of innerText To fix tests in firefox, see: https://stackoverflow.com/questions/1359469/innertext-works-in-ie-but-not-in-firefox * Update typescript, webpack and karma * Regenerate package-lock.json * JustinPealing#75 Add icon for bitmap * JustinPealing#75 Add icon for COND * JustinPealing#75 Add icon for Columnstore Index Scan Also added icons for other columnstore operations, just need to add test cases. * JustinPealing#75 Add test + css for Columnstore Index Insert icon * JustinPealing#75 add test for Columnstore Index Delete icon * Add test plan for Columnstore Index Update icon * JustinPealing#75 Test case + css for Columnstore Index Merge icon * JustinPealing#75 Populate Query * JustinPealing#75 Sequence Project icon * JustinPealing#75 Snapshot icon * JustinPealing#75 Icon for clustered index merge * JustinPealing#75 Add icon for Deleted Scan Also fix tests for Clustered Index Merge icon * Add icon for Index Insert * JustinPealing#75 Fix icon for index spool * JustinPealing#75 Add guesses for IndexDelete and IndexUpdate icons * JustinPealing#75 add icon for table merge * JustinPealing#75 fix icon for UDX nodes * JustinPealing#75 add unit test for Window Aggregate icon * JustinPealing#75 Update Catchall icon to a "C" icon Mostly used for cursors. * JustinPealing#75 Add icon for adaptive join * JustinPealing#75 add example plan for "Batch Hash Table Build" * JustinPealing#75 Add test plan for index delete * JustinPealing#75 add test plan for index update * Fix extension for test plan * Add icon for "Batch Hash Table Build" * JustinPealing#75 Add icon for Window Spool * Add icon for Window Aggregate * Fix filename for test plan * npm install * JustinPealing#82 - Fix Columnstore Index node labels * Initial implementation * Unit tests for execution mode icon The "Actual" execution mode overrides the estimated execution mode, if present. Mangled a couple of execution plans to provide test cases for the "ovveriding". * Adjust positon of 16x16 icons * Document "overlay" icons * Fix webpack minify config * Update version number * Fix npm version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/azuredatastudio#3491 and picks up upstream changes since April.