Mark Bluetooth.isSupported as experimental and add warning in KDoc
#753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
requested review from
Phoenix7351 and
davidtaylor-juul
and removed request for
a team
Phoenix7351
reviewed
Sep 19, 2024
| * This function is idempotent. | ||
| */ | ||
| @ExperimentalApi // Due to the inability to query Bluetooth support w/o showing a dialog on Apple, this function may be removed. | ||
| public suspend fun isSupported(): Boolean = isBluetoothSupported() |
There was a problem hiding this comment.
Does this get called anywhere in kable? We don't want to auto prompt just based on pulling in Kable.
There was a problem hiding this comment.
It does not. It is being used by my work-in-progress SensorTag sample refactor.
davidtaylor-juul
approved these changes
Sep 19, 2024
Phoenix7351
approved these changes
Sep 19, 2024
|
Closed in favor of #752. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach to #752. Rather than fake the BLE support on Apple, provide a KDoc warning.