Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bot: scenario rejoin #85

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix bot: scenario rejoin #85

merged 1 commit into from
Apr 19, 2024

Conversation

makiuchi-d
Copy link
Member

player1がwebsocket接続する前にplayer2が再入室してしまうと、
player1は切断メッセージを受け取れなくて、想定と異なるエラーになっていました。
(サーバ側の挙動自体は実装の想定どおりでしたが、テストシナリオの想定と異なっていました)

player1入室後にJoinedイベントを受け取ったことを確認してから再入室するようにしました。

player1がwebsocket接続する前にplayer2が再入室してしまうとplayer1は切断メッセージを受け取れなくて想定と異なるエラーになっていた
@makiuchi-d makiuchi-d requested review from methane and pandax381 March 21, 2024 09:12
@makiuchi-d makiuchi-d merged commit cffe95c into main Apr 19, 2024
5 checks passed
@makiuchi-d makiuchi-d deleted the fix-bot-rejoin branch April 19, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants