-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modpack fixes #293
Merged
Merged
Modpack fixes #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Type: Bug
Type: Improvement
Area: Backend
Related to the Python code that runs inside gunicorn
Priority: Normal
Type: Feature
Status: Ready
Area: Frontend
Related to HTML, JS, CSS, or other browser things
labels
Jun 26, 2020
HebaruSan
force-pushed
the
fix/modpack-add
branch
2 times, most recently
from
June 26, 2020 08:46
4774455
to
792f68e
Compare
HebaruSan
force-pushed
the
fix/modpack-add
branch
from
July 11, 2020 17:31
d6f78c6
to
230dba5
Compare
Change date of alembic script, code style fixes
DasSkelett
reviewed
Jul 20, 2020
DasSkelett
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good work, thanks! Maybe the packs get more attention in the future now that they're working better.
This was referenced Oct 5, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Backend
Related to the Python code that runs inside gunicorn
Area: Frontend
Related to HTML, JS, CSS, or other browser things
Area: Migration
Related to Alembic database migrations
Priority: Normal
Status: Ready
Type: Bug
Type: Feature
Type: Improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request attempts to make mod packs somewhat usable, plus a few convenience/usability fixes.
/packs/gameshort
route that shows a paginated listing of mod packs, 15 per page (half as many as for mods, since they're twice as wide). To make sure this is fast,ModList.created
is now indexed.Screenshots
Default focus of login:
Mod pack deletion confirmation:
Admin column in user list:
Admin indicator in profile:
Grant admin confirmation modal:
Mod selection bold highlights:
Add Mod button enabled after mod selection:
Mod version and game name in thumbnail, download link on hover, mod pack link at bottom (not logged in):
Same logged in:
Mod packs for a game:
Contents of a mod pack (not logged in):
Contents of a mod pack, follow link in thumbnail hover (logged in):
Editing mod pack with reasonably sized description: