Improve mod box appearance #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Type: Improvement
Priority: Normal
Status: Ready
Area: Frontend
This comment has been minimized.
This comment has been minimized.
HebaruSan
added
Status: Need Feedback
Status: In Progress
and removed
Status: Ready
labels
HebaruSan
force-pushed
the
feature/mod-box-band
branch
2 times, most recently
from
748aa6a
to
4c676ab
Compare
This comment has been minimized.
This comment has been minimized.
HebaruSan
force-pushed
the
feature/mod-box-band
branch
2 times, most recently
from
58d50f6
to
c3c9599
Compare
HebaruSan
added
Status: Ready
and removed
Status: In Progress
Status: Need Feedback
labels
This comment has been minimized.
This comment has been minimized.
HebaruSan
force-pushed
the
feature/mod-box-band
branch
6 times, most recently
from
3710c21
to
b6fdacb
Compare
DasSkelett
reviewed
May 15, 2021
HebaruSan
force-pushed
the
feature/mod-box-band
branch
from
b6fdacb
to
f8e9e07
Compare
HebaruSan
force-pushed
the
feature/mod-box-band
branch
from
f8e9e07
to
8f6fa9f
Compare
Closed
This was referenced Jul 31, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The mod box is somewhat ugly after #293. We gained the ability to follow and download mods in the thumbnail view, but it's done with text links floating over the right middle, which doesn't look good.
@V1TA5 created a mock-up of how it could look instead:
Changes
The mod box is reworked to look more like that. The download icon has a very close equivalent in the glyphicons font, and the follow button now follows a "favorites"-like idiom with an empty/filled star in the lower left. Both have tooltips indicating their function ("Follow", "Unfollow", "Download"). And the default mod thumbnail is replaced with a rocket flying out of a box on a dark background.
(Imagine that the rocket is centered, because we re-did it to be centered and these are old screenshots.)
Fixes #165.
Also the user profile now groups mods by game, with a little header showing the game name.