Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breadcrumbs - Rails resolve has_back_icon bug #1891

Merged
merged 2 commits into from
May 29, 2024
Merged

Breadcrumbs - Rails resolve has_back_icon bug #1891

merged 2 commits into from
May 29, 2024

Conversation

QuintonJason
Copy link
Contributor

@QuintonJason QuintonJason commented May 28, 2024 •
edited
Loading

Description

  • Resolve bug where setting has_back_icon: false was not working

Screenshots

Before After
28 05 2024_10 55 03_REC 28 05 2024_10 55 54_REC

Testing in sage-lib

  • Visit the breadcrumbs page and verify the back icon shows for that example. This shows that change is not breaking.
  • In VS Code, go tho this file, docs/app/views/examples/components/breadcrumbs/_preview.html.erb
  • In the SageBreadcrumbs on link 33 add has_back_icon: false,
  • Refresh your page and see that back icon is not there

Testing in kajabi-products

  1. (MEDIUM) Breadcrumbs - fix bug in the has_back_icon prop
    • Super admin -> Users

Related

DSS-624

@QuintonJason QuintonJason self-assigned this May 28, 2024
@QuintonJason QuintonJason marked this pull request as ready for review May 28, 2024 16:11
@QuintonJason QuintonJason merged commit ea31830 into develop May 29, 2024
6 checks passed
@QuintonJason QuintonJason deleted the DSS-624-breadcrumbs-back-icon-false-bug branch May 29, 2024 21:15
@QuintonJason QuintonJason mentioned this pull request May 29, 2024
Merged
1 task
ju-Skinner added a commit that referenced this pull request May 31, 2024
@QuintonJason @pixelflips
@monicawheeler @ju-Skinner @kajabi-bot
Next Version Relese (#1892)
4d579a8 
* fix(dropdown): add check for el (#1885)

* chore: update browserslist dependency

* chore: remove empty package.json dependencies block

* chore: update node engines to support v20 (#1888)

Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>

* fix(breadcrumbs): rails resolve has_back_icon bug (#1891)

* fix(breadcrumbs): rails resolve has back icon prop bug when value is false

* chore(breadcrumbs): add comment for code clarity

---------

Co-authored-by: Phillip Lovelace <phillip.lovelace@kajabi.com>
Co-authored-by: Monica Wheeler <monica.wheeler@kajabi.com>
Co-authored-by: Julian Skinner <ju-Skinner@users.noreply.github.com>
Co-authored-by: Julian Skinner <dev+github-bot@kajabi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ju-Skinner ju-Skinner ju-Skinner approved these changes

@pixelflips pixelflips pixelflips approved these changes

@monicawheeler monicawheeler Awaiting requested review from monicawheeler

Assignees

@QuintonJason QuintonJason

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuintonJason @pixelflips @ju-Skinner