Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs - Rails resolve has_back_icon bug #1891

Merged
merged 2 commits into from
May 29, 2024
Merged

Breadcrumbs - Rails resolve has_back_icon bug #1891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8987ee
fix(breadcrumbs): rails resolve has back icon prop bug when value is …
QuintonJason May 28, 2024
611be6f
chore(breadcrumbs): add comment for code clarity
QuintonJason May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docs/lib/sage_rails/app/views/sage_components/_sage_breadcrumbs.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<%
has_back_icon = component.has_back_icon.present? ? component.has_back_icon : component.items.length() == 1
# The intent is to set this prop to false unless the has_back_icon prop is explicitly set
has_back_icon = component.has_back_icon.nil? ? component.items.length() == 1 : component.has_back_icon
is_progressbar = component.is_progressbar.present? && component.is_progressbar
%>
<nav
Expand Down Expand Up @@ -38,7 +39,7 @@ is_progressbar = component.is_progressbar.present? && component.is_progressbar
<i class="sage-breadcrumbs__icon sage-icon-arrow-left" aria-hidden="true"></i>
<% end %>
<%= component.items[0][:text] %>
</a>
</a>
</p>
<% end %>
</nav>
Loading