feat(x/metrics): add module for emiting custom chain metrics #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
DracoLi,
nddeluca,
rhuairahrighairidh,
galxy25,
karzak,
drklee3 and
evgeniy-scherbina
galxy25
approved these changes
Aug 24, 2023
drklee3
approved these changes
Aug 25, 2023
pirtleshell
added
the
A:backport/kava_2222-10
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # app/app.go # go.mod
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # app/app.go # go.mod
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # app/app.go # go.mod
This was referenced Aug 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # go.mod
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2023
* initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md
This was referenced Aug 25, 2023
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…#1668) (#1672) * feat(x/metrics): add module for emiting custom chain metrics (#1668) * initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # app/app.go # go.mod * fix merge conflicts, add docker-build command --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…#1668) (#1673) * feat(x/metrics): add module for emiting custom chain metrics (#1668) * initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # app/app.go # go.mod * fix merge conflicts, add docker-build command --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…#1668) (#1674) * feat(x/metrics): add module for emiting custom chain metrics (#1668) * initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # app/app.go # go.mod * fix merge conflicts, add docker-build command --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
* initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # go.mod
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…#1668) (#1679) * feat(x/metrics): add module for emiting custom chain metrics (#1668) * initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md # go.mod * fix merge conflicts, add docker-build command
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…#1668) (#1676) * feat(x/metrics): add module for emiting custom chain metrics (#1668) * initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md * fix changelog merge conflict --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
pirtleshell
added a commit
that referenced
this pull request
Aug 25, 2023
…#1668) (#1677) * feat(x/metrics): add module for emiting custom chain metrics (#1668) * initialize x/metrics with metrics collection * include global labels in x/metrics metrics * add x/metrics spec * add x/metrics test coverage * update changelog (cherry picked from commit 9a0aed7) # Conflicts: # CHANGELOG.md * fix changlog conflicts --------- Co-authored-by: Robert Pirtle <Astropirtle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new module:
x/metricsA non-consensus breaking module for emitting chain metrics .
See spec for more details. It only emulates the forthcoming CometBFT (v0.38+) metric for
latest_block_heightduring blocksync. I decided to match the CometBFT prometheus gauges implementation (using go-kit) because it supports float64s, whereas cosmos-sdk telemetry only handles float32s.Checklist