Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(x/metrics): add module for emiting custom chain metrics (backport #1668) #1673

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Aug 25, 2023

This is an automatic backport of pull request #1668 done by Mergify.
Cherry-pick of 9a0aed7 has failed:

On branch mergify/bp/release/v0.18.x/pr-1668
Your branch is up to date with 'origin/release/v0.18.x'.

You are currently cherry-picking commit 9a0aed76.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   cmd/kava/cmd/app.go
	new file:   x/metrics/abci.go
	new file:   x/metrics/abci_test.go
	new file:   x/metrics/module.go
	new file:   x/metrics/spec/README.md
	new file:   x/metrics/types/keys.go
	new file:   x/metrics/types/metrics.go
	new file:   x/metrics/types/metrics_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md
	both modified:   app/app.go
	both modified:   go.mod

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* initialize x/metrics with metrics collection

* include global labels in x/metrics metrics

* add x/metrics spec

* add x/metrics test coverage

* update changelog

(cherry picked from commit 9a0aed7)

# Conflicts:
#	CHANGELOG.md
#	app/app.go
#	go.mod
@pirtleshell pirtleshell force-pushed the mergify/bp/release/v0.18.x/pr-1668 branch from bdb5688 to 687b1fc Compare August 25, 2023 20:41
@pirtleshell pirtleshell merged commit a4bda86 into release/v0.18.x Aug 25, 2023
1 check passed
@pirtleshell pirtleshell deleted the mergify/bp/release/v0.18.x/pr-1668 branch August 25, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant