Improved localization across languages to match macOS localization, with special focus on Simplified and Traditional Chinese (Rebased) #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Changed VoiceOver label for value-less control from 'Empty' to 'Not set' 2. Changed 'Type shortcut' to 'Press keys now', which is what macOS uses when recording a shortcut in System Preferences > Keyboard > Dictation > Customize… 3. Clarified the comment for 'Type shortcut' (now renamed 'Press keys now') to also indicate that it is used as a label for the control 4. Changed the name of 'Space' key in some languages to match the localization used by macOS AppKit under the description 'Name of Space key' (some languages were left untouched because macOS does not localize 'Space', e.g. Japanese and Thai)
…r match macOS system localization, based on the localization for macOS Automator actions for "recording" keyboard and mouse event 2. Fixed incorrect localization in Simplified Chinese for 'Cancel recording'. It carried the meaning 'Cancel audio recording'. 3. Updated 'Click to…' to better match the macOS localization in both Simplified and Traditional Chinese
…r double quotes in Simplified and Traditional Chinese. 2. Simplfiied the translation of "shortcut" in the error messages from "快捷键组合" to just"快捷键". "快捷键" carries the meaning of shortcut/hotkey in macOS. "组合" means "combination". Which is not wrong, but just extraneous.
… for "The \"%@\" shortcut can't be used because it's already used by a system-wide keyboard shortcut… Keyboard panel in System Preferences." with the equivalent found in macOS localization, which reads: "This keyboard shortcut is already in use by the system or another application. Please choose another shortcut or use Keyboard Preferences to customize other system shortcuts.". This phrase is found in SpotlightPref.lg in macOS localization.
… word Space in Thai when displaying a keyboard shortcut using a space key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Kentzo Hi, not sure if this is what you're looking for? I rebased the changes on top of your develop branch. #139