fix(InMemoryProvider): saveGuild and saveAxon inconsistency. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khaaz
requested changes
Feb 15, 2020
Khaaz
approved these changes
Feb 15, 2020
Khaaz
changed the title
Khaaz
requested changes
Feb 15, 2020
Khaaz
approved these changes
Feb 15, 2020
bsian03
reviewed
Feb 16, 2020
| } | ||
|
|
||
| async updateGuild(key, gID, value) { | ||
| const guild = await this.fetchGuild(gID); | ||
| guild[key] = value; | ||
| this.saveGuildSchema(gID, guild); | ||
| return guild; | ||
| return this.saveGuildSchema(gID, guild); |
There was a problem hiding this comment.
this.saveGuild instead of saveGuildSchema?
bsian03
reviewed
Feb 16, 2020
| @@ -82,7 +85,7 @@ class InMemoryProvider extends ADBProvider { | |||
| axonConf = await this.initAxon(); | |||
| } | |||
| axonConf[key] = value; | |||
| return axonConf; | |||
| return this.saveAxonSchema(axonConf); | |||
There was a problem hiding this comment.
this.saveAxon instead of saveAxonSchema?
Khaaz
added a commit
that referenced
this pull request
Feb 16, 2020
…com//pull/53/files#r379866275 and
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
Fixed two functions of InnMemoryProvider, init (was not implemented) and saveGuildSchema.
Status
Semantic versioning classification