Skip to content

Commit

Permalink
Drop outdated FIXME from test; NFC (#1397)
Browse files Browse the repository at this point in the history
This has been addressed in commit 4ccb1b2 ("Add convergent attribute
during reverse translation of OpControlBarrier (#1195)", 2021-09-06).

(cherry picked from commit 6fec8b9)
  • Loading branch information
svenvh committed Sep 29, 2022
1 parent affb4c2 commit 4297089
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion test/spirv-ocl-builtins-version.spt
Original file line number Diff line number Diff line change
Expand Up @@ -64,5 +64,4 @@
; CHECK-LLVM-SPV-IR: call spir_func void @_Z22__spirv_ControlBarrieriii(i32 2, i32 2, i32 784) [[attr]]
; CHECK-LLVM-SPV-IR: call spir_func void @_Z22__spirv_ControlBarrieriii(i32 2, i32 2, i32 2320) [[attr]]
; CHECK-LLVM-SPV-IR: call spir_func void @_Z22__spirv_ControlBarrieriii(i32 2, i32 2, i32 2832) [[attr]]
; FIXME: shall we apply convergent attribute to SPIR-V friendly IR representaiton as well?
; CHECK-LLVM-SPV-IR: attributes [[attr]] = { convergent nounwind }

0 comments on commit 4297089

Please sign in to comment.