Add convergent attribute during reverse translation of OpControlBarrier #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WDYT about 'Fix translation of OpControlBarrier' -> 'Add convergent attribute during reverse translation of OpControlBarrier' ? |
Fznamznon
reviewed
Sep 2, 2021
KornevNikita
changed the title
|
@MrSidims @Fznamznon @AlexeySachkov @mlychkov please take a look |
|
@KornevNikita please rebase the PR |
There is a workaround to keep convergent attr durring translation of OpControlBarrier to prevent optimization passes from making barrier calls control-dependent.
MrSidims
approved these changes
Sep 6, 2021
There was a problem hiding this comment.
LGTM
But I believe, that @Fznamznon concern wasn't addressed. I'm okay to remove W/A string.
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Feb 7, 2022
This has been addressed in commit 4ccb1b2 ("Add convergent attribute during reverse translation of OpControlBarrier (KhronosGroup#1195)", 2021-09-06).
AlexeySotkin
pushed a commit
that referenced
this pull request
Feb 9, 2022
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 13, 2022
…er (KhronosGroup#1195) There is a patch to keep convergent attr during translation of OpControlBarrier to prevent optimization passes from making barrier calls control-dependent.
Quetzonarch
pushed a commit
to Quetzonarch/SPIRV-LLVM-Translator
that referenced
this pull request
Jul 13, 2022
This has been addressed in commit 4ccb1b2 ("Add convergent attribute during reverse translation of OpControlBarrier (KhronosGroup#1195)", 2021-09-06).
svenvh
pushed a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 27, 2022
…er (KhronosGroup#1195) There is a patch to keep convergent attr during translation of OpControlBarrier to prevent optimization passes from making barrier calls control-dependent. (cherry picked from commit 4ccb1b2)
svenvh
added a commit
to svenvh/SPIRV-LLVM-Translator
that referenced
this pull request
Sep 27, 2022
This has been addressed in commit 4ccb1b2 ("Add convergent attribute during reverse translation of OpControlBarrier (KhronosGroup#1195)", 2021-09-06). (cherry picked from commit 6fec8b9)
svenvh
added a commit
that referenced
this pull request
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a patch to keep convergent attr during translation of
OpControlBarrier to prevent optimization passes from making barrier calls
control-dependent.