-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Gazebo Classic support and Update for MoveIt Jazzy/Rolling #228
base: main
Are you sure you want to change the base?
Conversation
Hi @sea-bass , |
Yep, it seems the |
Hi @sea-bass, |
Sounds good. In that case, the Of course, it's your choice, but this will make things harder for users to install on these later versions. My recommendation would be to remove it from the main branch but keep it around on Iron and earlier branches. |
f74b64c
to
d56b0e5
Compare
➕ yep probably best to create a branch where classic gazebo support is maintained and let Gazebo Classic is EOL in few months. |
This PR removes Gazebo Classic support, as this breaks builds, and fixes the existing (new) Gazebo support.
For more details, see #217 (comment)
Critically:
sim_ignition
arguments are gone, except for the calls to the macro from theros2_robotiq_gripper
repo... but I also have Remove mimic tags and renamesim_ignition
tosim_gazebo
PickNikRobotics/ros2_robotiq_gripper#54 to address this.sim_gazebo
arguments now refer to the "one and only" Gazebo