Maintain support for nested dialogs in v8 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KittyGiraudel
force-pushed
the
nested-dialogs
branch
2 times, most recently
from
b1f97e1
to
f63eeea
Compare
KittyGiraudel
force-pushed
the
nested-dialogs
branch
from
f63eeea
to
a1565c3
Compare
KittyGiraudel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request ensures nested dialogs will continue to work in version 8, despite being a questionable design pattern. Namely, we appear to have removed the necessary escape hatch in the recent library rewrite. This should bring it back, and adjust code and tests to make sure everything still works.
The fix for v7 is done in #399, and its documentation update is done in #400.