Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain support for nested dialogs in v8 #398

Merged
merged 5 commits into from
Aug 17, 2022
Merged

Maintain support for nested dialogs in v8 #398

merged 5 commits into from
Aug 17, 2022

Commits on Aug 11, 2022

  1. Properly nest nested dialogs’ DOM tree

    @KittyGiraudel
    KittyGiraudel committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    64bc1e8 View commit details
    Browse the repository at this point in the history

  2. Add a missing z-index declaration to dialogs

    @KittyGiraudel
    KittyGiraudel committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a237152 View commit details
    Browse the repository at this point in the history

  3. Bring back nested dialogs escape hatch in keydown listener

    @KittyGiraudel
    KittyGiraudel committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    0a8cc6c View commit details
    Browse the repository at this point in the history

  4. Adjust selector matching for closers to account for nested dialogs

    @KittyGiraudel
    KittyGiraudel committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    7d64b77 View commit details
    Browse the repository at this point in the history

  5. Update nested dialogs tests

    @KittyGiraudel
    KittyGiraudel committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a1565c3 View commit details
    Browse the repository at this point in the history