Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added valve opening and closing configuration for Sonoff TRVZB, v1.1.4 only #7130

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Added valve opening and closing configuration for Sonoff TRVZB, v1.1.4 only #7130

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d53fc37
Added valveOpeningDegree and valveClosingDegree to TRVZB
lcheng33775823 Feb 27, 2024
885ccf8
cancel readAtt
lcheng33775823 Feb 27, 2024
187d784
fix rule errors
lcheng33775823 Feb 28, 2024
220c31c
Change the description of TRVZB valve opening degree and closing degree
Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/devices/sonoff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,6 +622,34 @@ const definitions: Definition[] = [
unit: 'mV',
access: 'STATE_GET',
}),
numeric({
name: 'valve_opening_degree(version >= v1.1.4)',
cluster: 0xFC11,
attribute: {ID: 0x600B, type: 0x20},
description: 'Valve open position (percentage) control. ' +
'If the opening degree is set to 100%, the valve is fully open when it is opened. ' +
'If the opening degree is set to 0%, the valve is fully closed when it is opened, ' +
'and the default value is 100%, ' +
'The valve opening degree should be greater than or equal to the valve closing degree.',
valueMin: 0.0,
valueMax: 100.0,
valueStep: 1.0,
unit: '%',
}),
numeric({
name: 'valve_closing_degree(version >= v1.1.4)',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move (version >= v1.1.4) to the description (same for valve_opening_degree)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reminding, it has been modified

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version of which component does this refer to exactly?

cluster: 0xFC11,
attribute: {ID: 0x600C, type: 0x20},
description: 'Valve closed position (percentage) control. ' +
'If the closing degree is set to 100%, the valve is fully closed when it is closed. ' +
'If the closing degree is set to 0%, the valve is fully opened when it is closed, ' +
'and the default value is 100%. ' +
'The valve opening degree should be greater than or equal to the valve closing degree.',
valueMin: 0.0,
valueMax: 100.0,
valueStep: 1.0,
unit: '%',
}),
sonoffExtend.weeklySchedule(),
customTimeResponse('1970_UTC'),
],
Expand Down
Loading