Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for EZSP 13 (gecko 4.4.0, ncp 7.4.0.0) #858

Merged
merged 6 commits into from
Jan 8, 2024

Conversation

kirovilya
Copy link
Contributor

No description provided.

@@ -611,7 +611,7 @@ class EZSPAdapter extends Adapter {
}

public async supportsBackup(): Promise<boolean> {
return true;
return (this.driver && this.driver.ezsp && this.driver.ezsp.ezspV < 13);
Copy link

@xconverge xconverge Jan 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What change causes the need for backup to be disabled (for version 13) here, or is the version is 0 based?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also return this.driver?.ezsp?.ezspV < 13 can make it more concise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What change causes the need for backup to be disabled (for version 13) here, or is the version is 0 based?

I disable backup for ezsp 13... Receiving keys and storing them still needs to be worked out.

in any case, even if there is a backup, it is not restored yet - I have not yet completed the correct restoration

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What change causes the need for backup to be disabled (for version 13) here, or is the version is 0 based?

@kirovilya @xconverge Note! "This release of EmberZNet drops support for reading/writing network keys using our existing methods, breaking compatibility. The new commands thankfully maintain feature parity and include new features, allowing us to fully restore APS link keys." This might break backup and restore features. More info posted by puddly here -> zigpy/bellows#603

@kirovilya
Copy link
Contributor Author

can be merged. the current code may already work. without backup

@Koenkk Koenkk merged commit 460910c into Koenkk:master Jan 8, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 8, 2024

Awesome, many thanks for the super quick update!

@xconverge
Copy link

Thanks a lot @kirovilya !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants