Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more backup support for EZSP 13+ #888

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Jan 27, 2024

Continuing on #858

This should properly populate the existing fields for backup().
All the new key-related commands seem to use SLStatus (darn thing is uint32_t!).

@kirovilya As always, if you can double-check...

Still quite a lot more to do to support full backup... I'm still going through the code...

@kirovilya
Copy link
Contributor

This is great! Thank you for supporting the EZSP adapter (I’m terribly short of time).
In addition to backup, it is necessary to implement network restoration. I started doing it here.
https://github.com/kirovilya/zigbee-herdsman/tree/ezsp_restore

@Koenkk Koenkk merged commit 9b6c04b into Koenkk:master Jan 28, 2024
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jan 28, 2024

Thanks!

@Nerivec Nerivec deleted the base-backup-support-v13 branch January 28, 2024 14:39
@Nerivec
Copy link
Collaborator Author

Nerivec commented Jan 29, 2024

@kirovilya I noticed a few non-awaited promises while going through the EZSP codebase. Do you mind taking a look? You can probably identify faster than me what was not awaited on purpose and what should be awaited (they're all around frames handling). You can find them easily with the eslint rule "@typescript-eslint/no-floating-promises": "error",

@Koenkk we might want to add that rule as base, to force explicitly disabling lint for the lines that are not awaited on purpose? I didn't go through the list, but zstack seems to have a couple also. That's the kind of omission that can end up in weird-hard-to-trace errors...

@kirovilya
Copy link
Contributor

@Nerivec It seems that at the UART level one error handler does not wait for the reset.
The rest are not so critical (IMHO).

@Koenkk
Copy link
Owner

Koenkk commented Jan 29, 2024

we might want to add that rule as base, to force explicitly disabling lint for the lines that are not awaited on purpose? I didn't go through the list, but zstack seems to have a couple also. That's the kind of omission that can end up in weird-hard-to-trace errors..

Sounds good, please create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants