Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin chartsnap version to latest v0.3.1 #1054

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

czeslavo
Copy link
Contributor

What this PR does / why we need it:

Pins version of the chartsnap helm plugin that we use for golden testing to make sure we have reproducible results on CI.

chartsnap v0.3.0 had a breaking change that made the snapshot files use plain YAML instead of TOML (because of that there are many changes to those files in the PR).

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@czeslavo czeslavo self-assigned this Apr 11, 2024
@czeslavo czeslavo requested a review from a team as a code owner April 11, 2024 10:40
@czeslavo czeslavo marked this pull request as draft April 11, 2024 10:44
@czeslavo czeslavo force-pushed the chore/pin-chartsnap-version branch from e04315d to c7ca428 Compare April 11, 2024 11:03
@czeslavo czeslavo marked this pull request as ready for review April 11, 2024 11:05
@rainest rainest merged commit 7b2fb13 into main Apr 11, 2024
30 checks passed
@rainest rainest deleted the chore/pin-chartsnap-version branch April 11, 2024 19:42
@czeslavo czeslavo mentioned this pull request Apr 30, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants