-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(admission) add secret filter #1061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
feat/admission-cred
branch
from
April 26, 2024 22:03
cb91427
to
8cb667b
Compare
rainest
force-pushed
the
feat/admission-cred
branch
from
April 26, 2024 22:08
8cb667b
to
3e0736d
Compare
rainest
force-pushed
the
feat/admission-cred
branch
from
April 29, 2024 20:52
794ae51
to
55cec1d
Compare
rainest
force-pushed
the
feat/admission-cred
branch
from
April 29, 2024 20:57
55cec1d
to
25a39b3
Compare
randmonkey
previously approved these changes
Apr 30, 2024
4 tasks
I've regenerated golden files using the latest version of chartsnap to reduce changes volume: eceadb9 Chartsnap in v0.3.0 changed the format of golden files from TOML to YAML and I adopted this format in #1054. One mistake I made was to not enforce a local version to always match the one defined as desired. This should fix it for the future: #1064. |
pmalek
approved these changes
May 8, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Chart manifest component of Kong/kubernetes-ingress-controller#5856
Removes the
secrets
entry from the existing webhook.Adds an
ingressController.admissionWebhook.filterSecrets
boolean value. When true, it creates webhooks that accept only Secrets with known KIC-relevant labels. When false, it creates a webhook that accepts any (non-Helm) Secret.Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.