tests: run conformance on CI #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
run-conformance-on-ci
branch
8 times, most recently
from
c830ab0
to
121cd5e
Compare
|
Probably closes #134 |
pmalek
force-pushed
the
run-conformance-on-ci
branch
2 times, most recently
from
dc4cf44
to
62d4b04
Compare
pmalek
force-pushed
the
run-conformance-on-ci
branch
from
62d4b04
to
0d82edd
Compare
This was referenced May 28, 2024
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
This was referenced May 28, 2024
programmer04
approved these changes
May 28, 2024
pmalek
added a commit
that referenced
this pull request
May 28, 2024
* tests: run conformance on CI * chore: deduplicate metadata packages * chore: remove duplicate Namespace alias * tests(conformance): skip HTTPRouteWeight due to it being flaky * tests(conformance): use KIC's nightly * chore: add TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This re-enables conformance on CI.
In order to make the resource requirements smaller a custom
GatewayConfigurationis used which lowers those. Additionally, the most recent KIC version is used, which among others includes Kong/kubernetes-ingress-controller#6079.HTTPRouteWeightwas disabled because it failed several times on CI and locally. #295 tracks the re-introduction of it.Which issue this PR fixes
Fixes #134
Special notes for your reviewer:
I thought that this would require KIC version with Kong/kubernetes-ingress-controller#6097 but apparently that's not needed. Tried to pinpoint the culprit but failed. Now the tests are passing with KIC's nightly from 2024-05-28.