ci: don't run ee tests when license unavailable

[pmalek]

Since we can't reliably and securely give outside contributors access to our secrets we can't run the EE tests for those PRs.

This PR will allow us to accept patches contributed from outside of our org without enterprise tests failing.

[codecov-commenter]

Codecov Report

Base: 53.31% // Head: 53.31% // No change to project coverage 👍

Coverage data is based on head (800e6c1) compared to base (3a619dd).
Patch has no changes to coverable lines.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   53.31%   53.31%           
=======================================
  Files          46       46           
  Lines        4183     4183           
=======================================
  Hits         2230     2230           
  Misses       1478     1478           
  Partials      475      475           

Flag	Coverage Δ
2.1.4	40.06% <ø> (ø)
2.2.1.3	49.05% <ø> (ø)
2.2.2	40.06% <ø> (ø)
2.3.3	40.06% <ø> (ø)
2.3.3.4	49.05% <ø> (ø)
2.4.0	40.06% <ø> (ø)
2.4.1.3	49.05% <ø> (ø)
2.5.1	40.06% <ø> (ø)
2.5.1.2	49.05% <ø> (ø)
2.6.0	40.06% <ø> (ø)
2.6.0.2	49.05% <ø> (ø)
2.7.0	40.06% <ø> (ø)
2.7.0.0	49.05% <ø> (ø)
2.8.0	40.06% <ø> (ø)
2.8.2.2	?
3.0.1	39.39% <ø> (ø)
3.0.1.0	49.60% <ø> (ø)
3.1.0	39.39% <ø> (ø)
3.1.0.0	49.60% <ø> (ø)
community	40.06% <ø> (ø)
enterprise	50.27% <ø> (ø)
integration	53.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[rainest]

Is there a way you can skip this at the job level? I expect you can't check the env value, because the job is responsible for setting it, but you may be able to evaluate secrets.PULP_PASSWORD == '' directly, or move the license step into separate job and then test/use its output

[pmalek]

Is there a way you can skip this at the job level? I expect you can't check the env value, because the job is responsible for setting it, but you may be able to evaluate secrets.PULP_PASSWORD == '' directly, or move the license step into separate job and then test/use its output

As per my comment in the code : I've tried to do something similar but failed because the env and secrets context are not available at that level. We can do what you suggest sure. Feel free to submit a proposal :)

[rainest]

#247 takes the separate job route.

However, did we plan to make the "all enterprise" job a required check? I don't think there's a way to make that simultaneously succeed if all test jobs succeed or if all test jobs are skipped.

[pmalek]

#247 takes the separate job route.

However, did we plan to make the "all enterprise" job a required check? I don't think there's a way to make that simultaneously succeed if all test jobs succeed or if all test jobs are skipped.

I'm afk now but this works AFAIR (i.e if you skip all steps then the result is success)

[pmalek]

Closed in favor of #247