Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes right pane swagger preview #5457

Merged
merged 3 commits into from
Nov 24, 2022

Conversation

jackkav
Copy link
Contributor

@jackkav jackkav commented Nov 23, 2022

changelog(Improvements): Removed the Swagger preview from Design to provide a cleaner editing experience and in order to support OAS v3.1

As discussed with @mheap the right hand swagger ui pane crowds the editing experience and is of dubious value.
This change is also required in order to support OAS 3.1
Future work could include an export to request collection button and some way to send a request from the design view.
Question to reviewers: Is there anything we can do in this or a follow up PR that would help with removing this?

Previously:

image

Change:

image

@jackkav jackkav requested review from mheap and a team November 23, 2022 15:34
@mheap
Copy link
Member

mheap commented Nov 23, 2022

To be clear, I don't find it useful, but I imagine some consumers rely on it. I'd put this behind a toggle initially in case people need it

@filfreire
Copy link
Member

filfreire commented Nov 23, 2022

@jackkav I think this would fit with a follow-up PR to add a button to "Re-Generate" the requests on Debug tab from the spec. That would help us solve INS-2148

EDIT: @gatzjames PR #5458 addresses the concern - so nothing more to add to this 👍

@jackkav jackkav force-pushed the remove/swagger-preview branch from 1c58fab to 9dc76ca Compare November 24, 2022 13:49
@jackkav jackkav marked this pull request as ready for review November 24, 2022 13:50
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

John Wick approves this PR

Copy link
Contributor

@gatzjames gatzjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+💯
The debug view can handle most of the use-cases of the swagger-ui.
Also having the generate requests button closes the UX loop.

@gatzjames gatzjames force-pushed the remove/swagger-preview branch from 9dc76ca to 0ddb46e Compare November 24, 2022 13:59
@gatzjames gatzjames enabled auto-merge (squash) November 24, 2022 13:59
@gatzjames gatzjames merged commit f81bfd6 into Kong:develop Nov 24, 2022
@jlsajfj
Copy link

jlsajfj commented Dec 29, 2022

To be clear, I don't find it useful, but I imagine some consumers rely on it. I'd put this behind a toggle initially in case people need it

bump on this, maybe a toggle in the drop downs? I relied on this feature quite a bit to expedite my process, however I'm quite green with OpenAI which might be why I relied on it.

@jackkav jackkav deleted the remove/swagger-preview branch January 1, 2023 01:22
@nihadguluzade
Copy link

Maybe hide it for OpenAPI 3.1+ versions instead of removing it completely? It was a useful feature for me

@jackkav
Copy link
Contributor Author

jackkav commented Jan 1, 2023

A description of how it was useful would go long way in helping us incorporate your use case.

@desilvai-target
Copy link

desilvai-target commented Jan 3, 2023

My team used the preview pane heavily. I have green developers that don't yet know how to read a swagger spec as YAML. They will get there eventually, but that is just one more thing they need to learn (all at the same time). We relied on the preview pane to go over the work they would do and they would reference it from the spec I'd provide them. They checked their work against the spec.

Additionally, the preview pane prevented us from having to jump around the doc (we have a ton of structures that are referenced within the spec and having to jump back and forth is difficult). Perhaps we don't leverage the side pane enough, but it is one thing to follow the references around (especially for embedded object definitions) and it is quite another to see it rendered together. We have caught a number of mistakes by reading over the rendered preview.

Leaving us without a means of regenerating the preview from the document is a huge hurdle for us. What are the plans to replace the preview feature with some sort of render operation? Will that be coming soon?

@andrevtg
Copy link

andrevtg commented Jan 4, 2023

It was awesome for most newbies. It was the best WYSIWYG experience btw...

@CSnowss
Copy link

CSnowss commented Jan 4, 2023

I was quite surprised that this was removed as well. In fact, I opened a support ticket as I thought insomnia was broken with this the update. It was the main feature I used insomnia for.

OpenAPI specifications provide a an easily human readable form of documentation for users of your api when rendered in swagger-ui such as in Kong Developer Portal. Seeing how your API will be rendered in the swagger preview gives an idea of what it will look like when uploaded to the portal.

Ideally this feature would be added back with a toggle to disable it. If the rendering engine is not capable of supporting OAS3.1 yet, maybe disable the toggle only for those specs.

@yellowberryHN
Copy link

yellowberryHN commented Jan 13, 2023

As a temporary solution, you can revert to 2022.6.0, which still has the feature in question. Rather strange that they opted to remove it entirely instead of disabling it for unsupported files.

pavkout pushed a commit to pavkout/insomnia that referenced this pull request Jan 18, 2023
* removes right pane swagger preview

* package lock

* remove preview from smoke tests
@pexa-slee
Copy link

Any chance we can revert this change? I have non tecchy folk that design OAS' complain to me that they cannot preview what the doc looks like. If not, I will have to ask them to switch to stoplight instead. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.