Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the design view to use data loading/routing #5458

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Update the design view to use data loading/routing #5458

merged 3 commits into from
Nov 24, 2022

Conversation

gatzjames
Copy link
Contributor

@gatzjames gatzjames commented Nov 23, 2022 •
edited
Loading

Highlights:

  • Updates the design view to load/update data by using react-router's api
  • Linting and parsing are now done in the loader.
  • GitSync actions need to move to the routing paradigm to reflect changes when updating branches etc. (TBD in another PR)

Also, Closes INS-2148, INS-2169

@gatzjames gatzjames requested a review from a team November 23, 2022 15:30
@gatzjames gatzjames self-assigned this Nov 23, 2022
filfreire
filfreire approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@filfreire filfreire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Only nitpick is maybe putting the new button/section in the bottom.

image

@filfreire filfreire mentioned this pull request Nov 23, 2022
Merged
@filfreire filfreire requested a review from a team November 23, 2022 16:37
@filfreire filfreire mentioned this pull request Nov 23, 2022
Merged
@jackkav jackkav merged commit 32e788c into Kong:develop Nov 24, 2022
pavkout pushed a commit to pavkout/insomnia that referenced this pull request Jan 18, 2023
@gatzjames @pavkout
Update the design view to use data loading/routing (Kong#5458)
3af14d3 
* update design route

* Add button to generate a request collection from an api spec

* move the generate requests button to the bottom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filfreire filfreire filfreire approved these changes

@jackkav jackkav jackkav approved these changes

Assignees

@gatzjames gatzjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gatzjames @jackkav @filfreire