chore(venv): use 'exit' instead of 'return' upon shell error (#10855)

Shell utility 'return' can only be used to return from Shell functions. FTI-5071
Kong · May 16, 2023 · 77e4e12 · 77e4e12 · khcp-gha-bot · May 16, 2023
1 parent 0800353
commit 77e4e12
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/scripts/dependency_services/common.sh b/scripts/dependency_services/common.sh
@@ -34,7 +34,7 @@ $DOCKER_COMPOSE up -d
 
 if [ $? -ne 0 ]; then
     echo "Something goes wrong, please check $DOCKER_COMPOSE output"
-    return
+    exit 1
 fi
 
 # [service_name_in_docker_compose]="env_var_name_1:port_1_in_docker_compose env_var_name_2:port_2_in_docker_compose"

diff --git a/scripts/dependency_services/up.fish b/scripts/dependency_services/up.fish
@@ -8,7 +8,7 @@ bash "$cwd/common.sh" $KONG_SERVICE_ENV_FILE up
 
 if test $status -ne 0
     echo "Something goes wrong, please check common.sh output"
-    return
+    exit 1
 end
 
 source $KONG_SERVICE_ENV_FILE

diff --git a/scripts/dependency_services/up.sh b/scripts/dependency_services/up.sh
@@ -16,7 +16,7 @@ fi
 bash "$cwd/common.sh" $KONG_SERVICE_ENV_FILE up
 if [ $? -ne 0 ]; then
     echo "Something goes wrong, please check common.sh output"
-    return
+    exit 1
 fi
 
 . $KONG_SERVICE_ENV_FILE
-Original file line number
+Diff line change
@@ Expand Up / @@ -34,7 +34,7 @@ $DOCKER_COMPOSE up -d @@
     if [ $? -ne 0 ]; then
         echo "Something goes wrong, please check $DOCKER_COMPOSE output"
-        return
+        exit 1
     fi
     # [service_name_in_docker_compose]="env_var_name_1:port_1_in_docker_compose env_var_name_2:port_2_in_docker_compose"
@@ Expand Down @@