chore(dev): use 'exit' instead of 'return' upon shell error #10855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shell utility 'return' can only be used to return from Shell functions. FTI-5071
outsinre
force-pushed
the
FTI-5071-fix-a-bazel-shell-error
branch
from
74e4247 to
2905911
Compare
|
Could you back port it into CE? |
@chronolaw this is a CE PR. Will cherry-pick to EE by CE2EE merge. |
chronolaw
reviewed
May 13, 2023
chronolaw
approved these changes
May 15, 2023
oowl
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Shell utility 'return' can only be used to return from Shell functions.
Checklist
Full changelog
exitinstead ofreturnupon error.Issue reference
Fix FTI-5071