Skip to content

Commit

Permalink
chore(release): Boolean variables are passed as strings by Github Act…
Browse files Browse the repository at this point in the history
…ions (#10343)

Performing this comparison actually turns a "true" string into a false.
We already check for a string when consuming this environment variable
so there is no need to perform it here.

Signed-off-by: Tyler Ball <tyler.ball@konghq.com>
  • Loading branch information
tyler-ball authored Feb 23, 2023
1 parent 2f82ced commit 999f5be
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ jobs:

- name: Upload Packages to PULP
env:
OFFICIAL_RELEASE: ${{ github.event.inputs.official == true }}
OFFICIAL_RELEASE: ${{ github.event.inputs.official }}
PULP_HOST: https://api.download.konghq.com
PULP_USERNAME: admin
# PULP_PASSWORD: ${{ secrets.PULP_DEV_PASSWORD }}
Expand Down

1 comment on commit 999f5be

@khcp-gha-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel Build

Docker image available kong/kong:999f5bea44aa3092b61541a40adf1be81c6490b9
Artifacts available https://github.com/Kong/kong/actions/runs/4256993662

Please sign in to comment.