Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Boolean variables are passed as strings by Github Actions #10343

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

tyler-ball
Copy link
Contributor

Summary

Performing this comparison actually turns a "true" string into a false. We already check for a string when consuming this environment variable so there is no need to perform it here.

Without this change, releasing packages causes them to only end up in the internal channels.

…ions

Performing this comparison actually turns a "true" string into a false.
We already check for a string when consuming this environment variable
so there is no need to perform it here.

Signed-off-by: Tyler Ball <tyler.ball@konghq.com>
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 21, 2023
@curiositycasualty
Copy link
Contributor

Removed labels for branches where release.yml doesn't exist.

@curiositycasualty curiositycasualty self-requested a review February 21, 2023 22:55
@curiositycasualty curiositycasualty merged commit 999f5be into master Feb 23, 2023
@curiositycasualty curiositycasualty deleted the fix/official_var branch February 23, 2023 21:26
@mashapedeployment
Copy link
Contributor

The backport to release/3.2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.2.x release/3.2.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.2.x
# Create a new branch
git switch --create backport-10343-to-release/3.2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 999f5bea44aa3092b61541a40adf1be81c6490b9
# Push it to GitHub
git push --set-upstream origin backport-10343-to-release/3.2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.2.x

Then, create a pull request where the base branch is release/3.2.x and the compare/head branch is backport-10343-to-release/3.2.x.

tyler-ball added a commit that referenced this pull request Feb 23, 2023
…ions (#10343)

Performing this comparison actually turns a "true" string into a false.
We already check for a string when consuming this environment variable
so there is no need to perform it here.

Signed-off-by: Tyler Ball <tyler.ball@konghq.com>
(cherry picked from commit 999f5be)
curiositycasualty pushed a commit that referenced this pull request Feb 23, 2023
…ions (#10343) (#10361)

Performing this comparison actually turns a "true" string into a false.
We already check for a string when consuming this environment variable
so there is no need to perform it here.

Signed-off-by: Tyler Ball <tyler.ball@konghq.com>
(cherry picked from commit 999f5be)
This was referenced Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants