Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release/3.2.x] chore(release): Boolean variables are passed as strings by Github Actions #10361

Merged
merged 1 commit into from
Feb 23, 2023
Merged

[Backport release/3.2.x] chore(release): Boolean variables are passed as strings by Github Actions #10361

merged 1 commit into from
Feb 23, 2023

Conversation

tyler-ball
Copy link
Contributor

Backport 999f5be from #10343.

@tyler-ball
chore(release): Boolean variables are passed as strings by Github Act…
359a56e 
…ions (#10343)

Performing this comparison actually turns a "true" string into a false.
We already check for a string when consuming this environment variable
so there is no need to perform it here.

Signed-off-by: Tyler Ball <tyler.ball@konghq.com>
(cherry picked from commit 999f5be)
@tyler-ball tyler-ball added this to the 3.2.1 milestone Feb 23, 2023
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Feb 23, 2023
@curiositycasualty curiositycasualty merged commit 4aa5113 into release/3.2.x Feb 23, 2023
@curiositycasualty curiositycasualty deleted the backport-10343-to-release/3.2.x branch February 23, 2023 21:50
This was referenced Mar 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curiositycasualty curiositycasualty curiositycasualty approved these changes

Assignees
No one assigned
Labels
chore Not part of the core functionality of kong, but still needed size/XS
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tyler-ball @curiositycasualty