Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(makefile): remove remove target dependency to dependencies target #10494

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

fffonion
Copy link
Contributor

To preserve the previous behaviour.

This is a regression from #10442 and #10490.

Fixes https://github.com/Kong/kong-plugin/actions/runs/4421446482/jobs/7765323653

The previous dependency was:

install:
	@luarocks make OPENSSL_DIR=$(OPENSSL_DIR) CRYPTO_DIR=$(OPENSSL_DIR) YAML_DIR=$(YAML_DIR)

remove:
	-@luarocks remove kong

dependencies: bin/grpcurl
	@for rock in $(DEV_ROCKS) ; do \
	  if luarocks list --porcelain $$rock | grep -q "installed" ; then \
	    echo $$rock already installed, skipping ; \
	  else \
	    echo $$rock not found, installing via luarocks... ; \
	    luarocks install $$rock OPENSSL_DIR=$(OPENSSL_DIR) CRYPTO_DIR=$(OPENSSL_DIR) || exit 1; \
	  fi \
	done;

dev: remove install dependencies

@fffonion fffonion merged commit 66895f6 into master Mar 16, 2023
@fffonion fffonion deleted the fffonion-patch-1 branch March 16, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants