test(migration): support access to latest code #11020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
handle loaded module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm closing this PR because this is way too complicated than I thought when I came up with the solution. It does not worth the cost.
At some point, we need to refactor the
spec.helpers. It's too heavy, has too many dependencies and we even need the DB available to load the module. But for now, let's focus on the migration test.Summary
Migration tests are run with the old code, which cannot access the latest
spec.helpersandspec.helpers.*.We could mount the latest code into the test-running container and map the path with a hack.
Checklist
Full changelog
requirehackhttp_serverIssue reference
Fix KAG-1770
Unblock #11009