test(*): remove http_server #11009
Merged
test(*): remove http_server #11009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
previously approved these changes
Jun 5, 2023
bungle
dismissed
their stale review
I'll check it later again, seems like tests are failing.
|
@bungle The test is failing because the migration tests are using an older version of helpers which do not include the |
StarlightIbuki
force-pushed
the
test/depre-http-server
branch
from
5c0073e to
2d7b818
Compare
1 task
StarlightIbuki
force-pushed
the
test/depre-http-server
branch
2 times, most recently
from
2d5556d to
da1b786
Compare
hanshuebner
previously approved these changes
Jun 8, 2023
StarlightIbuki
force-pushed
the
test/depre-http-server
branch
2 times, most recently
from
6a1b7a3 to
d011180
Compare
StarlightIbuki
force-pushed
the
test/depre-http-server
branch
from
3dfc240 to
1b22bed
Compare
|
I got confused. The |
StarlightIbuki
force-pushed
the
test/depre-http-server
branch
from
bffad6d to
c8bf339
Compare
Fix KAG-1148 Co-authored-by: Hans Hübner <hans.huebner@gmail.com>
StarlightIbuki
force-pushed
the
test/depre-http-server
branch
from
c8bf339 to
b022475
Compare
hanshuebner
approved these changes
Jun 30, 2023
chobits
added a commit
that referenced
this pull request
Nov 29, 2023
windmgc
pushed a commit
that referenced
this pull request
Nov 29, 2023
chobits
added a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replacing uses of
helpers.http_serverwith the new implementation of HTTP mocking, which is more stable.Checklist
Issue reference
Fix KAG-1148