-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(*): http mock support specifying customized init_by_lua_block code #11331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windmgc
force-pushed
the
tests-http-mock-support-init-block
branch
from
July 31, 2023 08:25
28faffe
to
a1e1fd8
Compare
This commits has two changes: - Let http mock support specifying customized init_by_lua_block code - Fix the global patched assert function behavior to keep it same as the original one.
windmgc
force-pushed
the
tests-http-mock-support-init-block
branch
from
July 31, 2023 08:29
a1e1fd8
to
97ed3c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add tests for this new change.
Could you elaborate on why we need this?
windmgc
force-pushed
the
tests-http-mock-support-init-block
branch
2 times, most recently
from
July 31, 2023 15:00
6eddf3b
to
ffe3b7a
Compare
windmgc
force-pushed
the
tests-http-mock-support-init-block
branch
from
July 31, 2023 15:16
ffe3b7a
to
2e72981
Compare
test added. |
windmgc
force-pushed
the
tests-http-mock-support-init-block
branch
from
August 1, 2023 07:09
a326d9e
to
aea21af
Compare
windmgc
force-pushed
the
tests-http-mock-support-init-block
branch
from
August 1, 2023 07:23
aea21af
to
0fa9e28
Compare
StarlightIbuki
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
chobits
added a commit
that referenced
this pull request
Nov 29, 2023
windmgc
pushed a commit
that referenced
this pull request
Nov 29, 2023
chobits
added a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commits has two changes:
I'm writing some tests for the EE project and it will be useful if we can specify customized init code to run some code at init phase.
Checklist
Full changelog
Issue reference
Fix #[issue number]