chore(http_mock): improvements & tapping #11182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tieske
requested changes
Jul 6, 2023
|
please ensure that the documentation properly renders; here's how to check: cd kong/spec
ldoc .
open docs/index.htmlIt requires to have |
StarlightIbuki
force-pushed
the
test/http_mock_imporve
branch
3 times, most recently
from
cf3c815 to
f011815
Compare
oowl
approved these changes
Jul 6, 2023
|
I pushed a commit with some docs fixes, please verify, and if possible extend to the other modules that are currently undocumented. These new get rendered properly. |
Tieske
reviewed
Jul 6, 2023
|
fyi; the reason I'm pushing on this is because we have been neglecting the documentation in the helpers. Mostly because not everyone realizes this is actually user-facing stuff. We should pay more attention to this. Plugin developers will use |
StarlightIbuki
force-pushed
the
test/http_mock_imporve
branch
from
0fbb5a3 to
0791108
Compare
bug fix: assert turthy alias for not_all more checks better comment&document some fixes wrt docs rendering Co-authored-by: Thijs Schreijer <thijs@thijsschreijer.nl>
StarlightIbuki
force-pushed
the
test/http_mock_imporve
branch
from
0791108 to
d5432de
Compare
Tieske
approved these changes
Jul 10, 2023
|
still could approve 🤷 , so just did |
chobits
added a commit
that referenced
this pull request
Nov 29, 2023
windmgc
pushed a commit
that referenced
this pull request
Nov 29, 2023
chobits
added a commit
that referenced
this pull request
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce tapping for testing, especially OIDC's behavior when sending requests to IDP.
bugfix: assert truthy
alias for not_all
more checks
better comment&document
Checklist
Issue reference
N/A