-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kong.conf): add section for wasm nginx.conf directives #11387
Conversation
Not sure if this needs a backport to |
This commit 550ef15 says that the autodocs scripts that used to generate Markdown from this were replaced by a script in Enterprise which builds both EE and OSS docs, so there should be a script somewhere that allows building a previewable Markdown... 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just gave it a quick skim, but will get back to it more carefully tomorrow!
Labeling this one for backport for consistency's sake. It's a doc-only change, so it's harmless and doesn't necessitate a new release. If that's not desired, feel free to remove the label. |
Thanks.
You don't need to backport this as far as I know. The process runs on the checkedout branch when you run the script. |
41a6fec
to
8118658
Compare
8118658
to
596db9a
Compare
@locao could I get a +1 on this? |
It's pretty wordy because there's a lot to explain. I'm also not sure what it will look like when rendered for docs.konghq.com, so if anyone has pointers on how to preview the end result, let me know.