fix(conf_loader): adjust Wasm shm_kv nginx.conf prefix #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The prefix for Wasm's
shm_kvnginx.conf directive was initially created asnginx_wasm_shm_, but this is ambiguous withshm_queue(which we don't yet support but plan to). This PR changes the prefix tonginx_wasm_shm_kv_{name}so that we can later addnginx_wasm_shm_queue_{name}.See this discussion for a little more background.
NOTE: this is a breaking change (as called out in the changelog entry), but Wasm is still in beta/tech preview status, so such changes are legal.
Checklist
Issue reference
KAG-2355