fix(certificate): properly throw errors when parsing certificate from the vault #14212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the vault `get_certificate` was not handling certificate parsing errors after a vault update. This fixes it.
github-actions
bot
added
core/proxy
cherry-pick kong-ee
windmgc
approved these changes
Jan 23, 2025
|
Although the PR is straight enough to understand and seems not bring any side effects, do we need a test case for it? |
@liverpool8056 This change does not affect behavior; it only affects the error log output for easy troubleshooting. Therefore, I don't think it's necessary to add tests for this minor change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_certificatewas not handling certificate parsing errors after a vault update. This fixes it.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix FTI-6392