Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(certificate): properly throw errors when parsing certificate from the vault #14212

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/fix-error-handle-certificate.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: "Fixed an issue where the error was not thrown when parsing the certificate from vault."
type: bugfix
scope: Core
2 changes: 1 addition & 1 deletion kong/runloop/certificate.lua
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ local function get_certificate(pk, sni_name, ws_id)
pk, sni_name, ws_id)

if certificate and hit_level ~= 3 and certificate["$refs"] then
certificate = parse_key_and_cert(kong.vault.update(certificate))
certificate, err = parse_key_and_cert(kong.vault.update(certificate))
end

return certificate, err
Expand Down
Loading