Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db) blue/green migration for route regex path #9334

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

StarlightIbuki
Copy link
Contributor

@StarlightIbuki StarlightIbuki commented Aug 29, 2022

The migration steps should happen in the up phase, not the teardown phase.

Notice this PR needs cooperation from 2.8.x.x.

fix FT-3293

The steps of migration should happen at up phase, not teardown phase.

fix FT-3293
@jschmid1
Copy link
Contributor

jschmid1 commented Sep 1, 2022

@suika-kong could you please adapt the commit message so that it is compliant to https://www.conventionalcommits.org/en/v1.0.0/

@bungle
Copy link
Member

bungle commented Sep 1, 2022

@suika-kong could you please adapt the commit message so that it is compliant to https://www.conventionalcommits.org/en/v1.0.0/

I think this is our format:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#commit-message-format

@bungle
Copy link
Member

bungle commented Sep 1, 2022

If I remember correctly, the original idea of migrations was to do:

  1. schema changes in up (non-destructive)
  2. data changes in finish

We have done data changes in up before, and sometimes they work, and sometimes they cause huge issues. Especially if there are both schema changes and data changes. This is especially problematic in Cassandra clusters, if I remember correctly.

That said I know that some migrations are impossible to do that way. Which usually means they need to be done in parts, in several minor releases, or apply code changes. This is cumbersome for sure too.

@yzyyi
Copy link

yzyyi commented Sep 1, 2022

Is this one still target 3.0? Trying to decide if needed cherrypick

@StarlightIbuki StarlightIbuki added this to the 3.0 milestone Sep 2, 2022
@StarlightIbuki
Copy link
Contributor Author

We decided to only support blue/green migration from 2.8.1.5 where we support both ~ and auto-detection(but users are not allowed to create ~ regex path).

@guanlan guanlan merged commit e580154 into master Sep 2, 2022
@mayocream mayocream deleted the fix/regex_migration branch September 2, 2022 07:57
StarlightIbuki added a commit that referenced this pull request Sep 2, 2022
The steps of migration should happen in the up phase, not the teardown phase.

fix FT-3293
StarlightIbuki added a commit that referenced this pull request Sep 2, 2022
The steps of migration should happen in the up phase, not the teardown phase.

fix FT-3293
StarlightIbuki added a commit that referenced this pull request Sep 21, 2022
support blue/green migration from 2.8.x to 3.0.x.
This PR needs #9334 to cooperate.

Fix FT-3293
locao pushed a commit that referenced this pull request Jun 21, 2024
Access to `tls` table was missing

Cherry-picked from #13032

Co-authored-by: Vìncent Le Goff <vince.legoff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants