-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(db) blue/green migration for route regex path #9334
Conversation
The steps of migration should happen at up phase, not teardown phase. fix FT-3293
@suika-kong could you please adapt the commit message so that it is compliant to https://www.conventionalcommits.org/en/v1.0.0/ |
I think this is our format: |
If I remember correctly, the original idea of migrations was to do:
We have done data changes in That said I know that some migrations are impossible to do that way. Which usually means they need to be done in parts, in several minor releases, or apply code changes. This is cumbersome for sure too. |
Is this one still target 3.0? Trying to decide if needed cherrypick |
We decided to only support blue/green migration from 2.8.1.5 where we support both |
The steps of migration should happen in the up phase, not the teardown phase. fix FT-3293
The steps of migration should happen in the up phase, not the teardown phase. fix FT-3293
support blue/green migration from 2.8.x to 3.0.x. This PR needs #9334 to cooperate. Fix FT-3293
Access to `tls` table was missing Cherry-picked from #13032 Co-authored-by: Vìncent Le Goff <vince.legoff@gmail.com>
The migration steps should happen in the up phase, not the teardown phase.
Notice this PR needs cooperation from 2.8.x.x.
fix FT-3293