Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core) support route migration #9376

Merged
merged 7 commits into from
Sep 21, 2022

Conversation

StarlightIbuki
Copy link
Contributor

This PR is to support blue/green migration from 2.8.x to 3.0.x.

This PR needs #9334 to cooperate.

Fix FT-3293

@StarlightIbuki StarlightIbuki added this to the 3.0 milestone Sep 9, 2022
@chronolaw
Copy link
Contributor

I think it should not be in 3.0 milestone, it belongs to 2.8.x

@guanlan guanlan modified the milestones: 3.0, 2.8.2 Sep 9, 2022
@pull-request-size pull-request-size bot added size/M and removed size/S labels Sep 15, 2022
@ADD-SP
Copy link
Contributor

ADD-SP commented Sep 15, 2022

I have test this PR locally for Traditional Mode.

  1. Bootstrap Postgres using image kong:2.7.1-alpine
  2. Start container kong:2.7.1-alpine
  3. Insert a prefix route, insert a regex route.
  4. Keep traffic on kong-2.7.1
  5. Run kong migrations up using this PR.
  6. Start Kong using this PR.
  7. Keep traffic on this PR's Kong
  8. Stop container kong:2.7.1-alpine.
  9. Run kong migrations finish using this PR's Kong.
  10. Run kong migrations up using image kong:3.0.0-alpine
  11. Start container kong:3.0.0-alpine.
  12. Keep traffic on kong-3.0.0.
  13. Stop this PR's Kong.
  14. Run kong migrations finish using image kong:3.0.0-alpine.
  15. Restart container kong:3.0.0-alpine.

During the test, all traffic was 200.

kong/router.lua Outdated Show resolved Hide resolved
@StarlightIbuki
Copy link
Contributor Author

Maybe we should merge this and then cherry-pick to EE with squashed commit.

@StarlightIbuki StarlightIbuki merged commit fd4a159 into release/2.8.x Sep 21, 2022
@bungle bungle deleted the fix/migrate_regex_support branch October 14, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants