Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log metadata for Konnect requests and provide KIC metadata with requests to Konnect #6240

Closed
4 tasks
Tracked by #6388
rainest opened this issue Jun 24, 2024 · 1 comment
Closed
4 tasks
Tracked by #6388
Assignees
Labels
area/feature New feature or request area/konnect Issues and PRs related to Konnect release/not-required this is not a hard requirement for the release, it can be considered a "nice to have"
Milestone

Comments

@rainest
Copy link
Contributor

rainest commented Jun 24, 2024

Partially copied from https://github.com/Kong/team-k8s/issues/307. That internal issue has some additional background.

Brief version is that KIC sends requests to Konnect to obtain licenses, push configuration, push metrics, etc. These requests sometimes go wrong. When those requests fail, we would like to identify related events in logs on both the KIC and Konnect sides. We can log Konnect request metadata and include our own metadata in these requests to assist correlation.

AC:

  • KIC instances log upstream request IDs when interacting with Konnect infrastructure. Konnect-side infrastructure provides x-datadog-trace-id to downstream clients.
  • When sending requests, KIC instances provides identifying information indicating which replica and replica set (e.g. Pod, Deployment) they belong to.
  • KIC optionally provides its own request ID and other useful metadata we'd like to see in Konnect logs.
  • We have documentation for operations and support teams to find and use these logs.
@rainest rainest added area/feature New feature or request area/konnect Issues and PRs related to Konnect labels Jun 24, 2024
@rainest rainest added this to the KIC v3.3.x milestone Jun 24, 2024
@czeslavo
Copy link
Contributor

Kind of a duplicate for #6236. I think we can use #6236 to define a final scope of what we'd like to do in #6240.

@randmonkey randmonkey added the release/not-required this is not a hard requirement for the release, it can be considered a "nice to have" label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request area/konnect Issues and PRs related to Konnect release/not-required this is not a hard requirement for the release, it can be considered a "nice to have"
Projects
None yet
Development

No branches or pull requests

3 participants