Support for the serialization of DataframeConvertible values in ValueColumns has been added to enhance visualization in the KTNB plugin. #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the `CellKind` enum with a `DataFrameConvertable` type. Updated JSON writing logic to handle `DataFrameConvertable` cells and added utility function to check if an object is convertible to DataFrame.
Also refactor JSON encoding to use the unified EncodingOptions interface
Jolanrensen
approved these changes
Aug 13, 2024
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/columns/CellKind.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/io/json.kt
Outdated
Show resolved
Hide resolved
core/src/test/kotlin/org/jetbrains/kotlinx/dataframe/io/ImageSerializationTests.kt
Outdated
Show resolved
Hide resolved
Replace `EncodingOptions` with `CustomEncoder` to improve flexibility and clarity in the JSON serialization process. This update includes introducing `CustomEncoder` interface and dedicated encoders for DataFrameConvertable and BufferedImage, alongside necessary adjustments across related classes and tests.
|
I’ve pushed a refactoring that replaces EncodingOption with a CustomEncoder interface. You might want to take a look, @Jolanrensen @koperagen. |
Jolanrensen
approved these changes
Aug 14, 2024
core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/impl/io/writeJson.kt
Outdated
Show resolved
Hide resolved
|
Generated sources will be updated after merging this PR. |
ermolenkodev
force-pushed
the
ermolenko/KTNB-668
branch
from
debf9bb
to
c8426ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the value within the ValueColumn can be converted to a dataframe, it will be serialized in a manner similar to the FrameColumn values. Consequently, it will be visualized as a nested table in the KTNB plugin.